This commit fixed Client spoof to be injectable directly to the minecraft library, also adds new types of client spoofs #55
Conversation
…raft library, also adds new types of client spoofs
WalkthroughThe changes introduce the functionality to intercept the game's handling of joining a server to modify player settings and spoof client information. This involves adding a mixin to hook into the network handling, enhancing the Changes
Sequence Diagram(s)sequenceDiagram
participant Player
participant GameClient
participant MixinClientSpoofer
participant NetHandlerPlayClient
participant Server
Player->>GameClient: Join Server
GameClient->>Server: Send Join Request
Server->>GameClient: Response with S01PacketJoinGame
GameClient->>MixinClientSpoofer: handleJoinGame(packetIn, callbackInfo)
MixinClientSpoofer->>NetHandlerPlayClient: Modify join game behavior
NetHandlerPlayClient->>GameClient: Complete Join Process
GameClient->>Player: Player joined server with modified settings
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/main/java/keystrokesmod/mixins/impl/network/MixinClientSpoofer.java (1 hunks)
- src/main/java/keystrokesmod/module/impl/other/ClientSpoofer.java (3 hunks)
- src/main/resources/mixins.raven.json (2 hunks)
Additional comments not posted (8)
src/main/resources/mixins.raven.json (3)
3-3: LGTM!The addition of the
minVersionfield is correct and syntactically valid.
38-38: LGTM!The addition of
network.MixinClientSpooferto theclientsection is correct and ensures the mixin is recognized by the client.
41-43: LGTM!The addition of the
injectorssection withdefaultRequireset to 1 is correct and syntactically valid.src/main/java/keystrokesmod/mixins/impl/network/MixinClientSpoofer.java (1)
1-56: LGTM!The mixin class
MixinClientSpooferand the methodhandleJoinGameare correctly implemented. The method processes the join game packet and modifies player settings appropriately. The custom payload packet sent using theClientSpooferclass is also correctly handled.src/main/java/keystrokesmod/module/impl/other/ClientSpoofer.java (4)
4-4: LGTM!The import statement for
Ravenis correct and syntactically valid.
23-23: LGTM!The addition of the
currentSpooffield and the updates to theonUpdatemethod are correct. The method correctly updatescurrentSpoofand handles different cases based on the mode. The logic for enabling and disabling modules is also correct.Also applies to: 30-39
49-51: LGTM!The
getBrandNamemethod correctly returnsBrandInfobased on the current spoof mode. TheBrandInfoclass is correctly implemented withbrandandchannelfields.Also applies to: 54-60
65-83: LGTM!The changes to the
SpoofModeenum correctly add new modes and update the constructor to include thechannelparameter. ThegetNamesmethod is correctly updated to return an array of mode names.
|
very pro module only 4 hours was needed 👍 |
|
Fixes #31 |
wdym? also if ur talking about me taking this much time, no I went out for dinner and I dont code in one sitting |
Clear sarcasm |
|
No Compat issue by overwrite? |
|
Hey sorry for the late reply, no there won't be any combat issues. |
Summary by CodeRabbit
New Features
Enhancements
Compatibility