Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken Windows CI builds. #147

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

gruenich
Copy link
Contributor

[example] Remove unnecessary include unistd.h from ?itersol.c

@gruenich
Copy link
Contributor Author

@xiaoyeli Please merge this to fix the CI tests for windows.

  1. Why were the wrong includes of unistd.h added back to the examples?
  2. Why was a merge request accepted, that failed the CI tests? That is the purpose of the tests. If you have issues with fixing broken CI prior to merging, please reach out to me and I try to help.

@gruenich gruenich force-pushed the feature/fix-windows-ci branch from 99e669c to ea1f06e Compare July 24, 2024 20:13
@xiaoyeli xiaoyeli merged commit b3f85b4 into xiaoyeli:master Jul 24, 2024
4 checks passed
@xiaoyeli
Copy link
Owner

We are using macro files to generate 4 precision files. While I was updating the macro files for some other bug fixes, I missed this fix.

@xiaoyeli
Copy link
Owner

Now I updated the macro file with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants