C macro exposed in interface

[jeanlucf22]

utils_dist.h is included in superlu_defs.h, and thus exposes the following definition of EMPTY in the public interface:

superlu_dist/SRC/util_dist.h

Line 74 in 324d65f

#define EMPTY (-1)

This can cause a naming conflict when this include file is included ahead of another one using the same string "EMPTY". I just experienced that conflict with a CUDA header. I am able to avoid this issue by including the superlu header files after the CUDA ones in my code, but it would be better practice if that EMPTY string was never exposed in the public interface (I don't think it needs to). It may save some headaches to future users.

[jhux2]

This has also been reported by a Trilinos user in trilinos/Trilinos#11839.

[xiaoyeli]

I just pushed a commit in master, renamed all EMPTY by SLU_EMPTY.

[jeanlucf22]

That should help. Thanks!

[jhux2]

@xiaoyeli Thank you! Btw, I noticed in the same file that the constants TRUE and FALSE might cause clashes with other packages.

superlu_dist/SRC/util_dist.h

Lines 74 to 80 in 09cb143

	#define SLU_EMPTY (-1)
	#ifndef FALSE
	#define FALSE (0)
	#endif
	#ifndef TRUE
	#define TRUE (1)
	#endif

[haampie]

Could you please prefix the other defines that are in public headers too @xiaoyeli?

[xiaoyeli]

There are lots of places using FALSE/TRUE; changing it will affect many files.
I would think any other packages would define FALSE to be 0, should not cause conflict.