Skip to content

Commit

Permalink
chore: downgrade github artifact to v3 from v4 for release docker image.
Browse files Browse the repository at this point in the history
artifact v4 do not support upload artifact with the same name, https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact , so this is working for downgrade v4 to v3, until we get rid of using github jobs to build multi-architecture container images.

see #809

Signed-off-by: Lan Liang <[email protected]>
  • Loading branch information
liangyuanpeng authored and Phoenix500526 committed May 30, 2024
1 parent fcd9195 commit 239cb77
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ updates:
# 5 by default
# see https://docs.github.com/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#open-pull-requests-limit
open-pull-requests-limit: 10
ignore:
- dependency-name: 'actions/upload-artifact'
#ignore all updates greater than or equal to version 4
versions: '>= 4'
- dependency-name: 'actions/download-artifact'
versions: '>= 4'
- package-ecosystem: "cargo"
directory: "/"
schedule:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
touch "/tmp/digests/${digest#sha256:}"
- name: Upload Digest
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: digests
path: /tmp/digests/*
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/merge_image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
name: Merge Docker Image
steps:
- name: Download Digests
uses: actions/download-artifact@v4
uses: actions/download-artifact@v3
with:
name: digests
path: /tmp/digests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ jobs:
touch "/tmp/digests/${digest#sha256:}"
- name: Upload Digest
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: startsWith(matrix.job.platform, 'linux/')
with:
name: digests
Expand Down

0 comments on commit 239cb77

Please sign in to comment.