Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Some request from an xline client won't be checked in KvStore #384

Closed
1 task done
Phoenix500526 opened this issue Jul 17, 2023 · 1 comment
Closed
1 task done
Labels
bug Something isn't working

Comments

@Phoenix500526
Copy link
Collaborator

Description about the bug

Currently, Xline supports two different clients: the etcd client and the Xline client.

For the etcd client, its request path is as follows:
etcd client — RPC call —> KvServer — inner client propose —> CurpServer —> Command Executor —> KvStore

For the Xline client, its request path is as follows:
Xline client — outer client —> CurpServer —> Command Executor —> KvStore

As shown in the request paths above, Xline client requests do not pass through KvServer. Therefore, some backend-related request checks, such as check_range_request, are not invoked when interacting with an Xline client and Xline. Hence, we need to add the corresponding request checks to KvStore based on the request path of the Xline client.

Version

0.4.1 (Default)

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Phoenix500526 Phoenix500526 added the bug Something isn't working label Jul 17, 2023
@Phoenix500526
Copy link
Collaborator Author

Same as issue #398, and resolved in pr #394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant