-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/compactor #311
Merged
Merged
feat/compactor #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix500526
force-pushed
the
feature/compactor
branch
3 times, most recently
from
June 27, 2023 04:55
43cc402
to
20c0240
Compare
Phoenix500526
force-pushed
the
feature/compactor
branch
from
June 28, 2023 09:00
20c0240
to
2bc8908
Compare
Phoenix500526
force-pushed
the
feature/compactor
branch
6 times, most recently
from
July 2, 2023 11:49
49bbbf5
to
e84662f
Compare
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 3, 2023 15:08
59fe258
to
2262020
Compare
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 4, 2023 01:12
2262020
to
26fab31
Compare
Phoenix500526
force-pushed
the
feature/compactor
branch
3 times, most recently
from
July 5, 2023 07:24
7c3c174
to
a83a9ae
Compare
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 6, 2023 06:29
a83a9ae
to
f404ad1
Compare
bsbds
reviewed
Jul 6, 2023
iGxnon
reviewed
Jul 10, 2023
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 10, 2023 02:35
f404ad1
to
add7c47
Compare
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 10, 2023 03:15
add7c47
to
bd996f6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 51.36% 53.42% +2.06%
==========================================
Files 95 96 +1
Lines 14069 14847 +778
Branches 14069 14847 +778
==========================================
+ Hits 7226 7932 +706
- Misses 6376 6420 +44
- Partials 467 495 +28
☔ View full report in Codecov by Sentry. |
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 10, 2023 03:34
bd996f6
to
210d59b
Compare
themanforfree
previously approved these changes
Jul 18, 2023
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 18, 2023 13:13
9eae316
to
d613268
Compare
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 19, 2023 02:39
d613268
to
164982f
Compare
bsbds
reviewed
Jul 21, 2023
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 24, 2023 02:48
164982f
to
8433e51
Compare
1. implement index compact logic and add test to cover 2. implement KvStore compact logic and add test to cover Refs: xline-kv#188 Signed-off-by: Phoeniix Zhao <[email protected]>
Refs: xline-kv#188 Signed-off-by: Phoeniix Zhao <[email protected]>
Refs: xline-kv#188 Signed-off-by: Phoeniix Zhao <[email protected]>
Refs: xline-kv#188 Signed-off-by: Phoeniix Zhao <[email protected]>
Refs: xline-kv#188 Signed-off-by: Phoeniix Zhao <[email protected]>
Refs: 188 Signed-off-by: Phoeniix Zhao <[email protected]>
Refs: xline-kv#188 Signed-off-by: Phoeniix Zhao <[email protected]>
Refs: 188 Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
feature/compactor
branch
2 times, most recently
from
July 24, 2023 11:32
49e0fac
to
28cadab
Compare
iGxnon
reviewed
Jul 25, 2023
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 25, 2023 05:01
fa7e0f5
to
3f8cedb
Compare
* unify the argument between PutKeyValue and DeleteKeyValue * move compact.rs into compact mod * using a bounded channel to replace the unbounded channel (compact_task_tx, compact_task_rx) Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
feature/compactor
branch
from
July 25, 2023 07:36
3f8cedb
to
44d8fc4
Compare
themanforfree
approved these changes
Jul 25, 2023
iGxnon
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read #188 for more details.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)