Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reimplement curp client fetch cluster #1005

Open
wants to merge 9 commits into
base: refactor-curp-client
Choose a base branch
from

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Oct 9, 2024

Depends-On: #981

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Copy link

github-actions bot commented Nov 9, 2024

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the Stale label Nov 9, 2024
Copy link

This PR was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this Nov 23, 2024
@bsbds bsbds reopened this Dec 3, 2024
@bsbds bsbds marked this pull request as ready for review December 3, 2024 11:48
@mergify mergify bot requested a review from a team December 3, 2024 11:48
@bsbds bsbds force-pushed the impl-curp-client-fetch-cluster branch from 9c4c059 to 0755a3c Compare December 3, 2024 11:51
@@ -64,6 +64,13 @@ pub(super) struct Unary<C: Command> {
last_sent_seq: AtomicU64,
/// marker
phantom: PhantomData<C>,

#[allow(dead_code)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not deadcode

@mergify mergify bot requested a review from a team December 3, 2024 12:00
@github-actions github-actions bot removed the Stale label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants