Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issues that use many '/tmp/xxx' as temp directory #1013

Closed

Conversation

Standing-Man
Copy link

@Standing-Man Standing-Man commented Oct 24, 2024

Fixed #933.

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

i solved this issue that use many tmp/xxx as temp directory in many test files.

  • what changes does this pull request make?

i used the tempfile cargo to replace the hardcoded paths and formatted temp
directory usage.

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

No need to worry about folder name collisions; each test will always use a unique folder.

@mergify mergify bot requested a review from a team October 24, 2024 08:21
Copy link

mergify bot commented Oct 24, 2024

@JianMinTang Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft October 24, 2024 08:44
@mergify mergify bot added the CI:fail CI has failed label Oct 24, 2024
Standing-Man and others added 4 commits October 24, 2024 17:37
Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.89 to 1.0.90.
- [Release notes](https://github.com/dtolnay/anyhow/releases)
- [Commits](dtolnay/anyhow@1.0.89...1.0.90)

---
updated-dependencies:
- dependency-name: anyhow
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: JianMinTang <[email protected]>
@Standing-Man Standing-Man force-pushed the feature/ReplaceHardCoding/933 branch from be42d7b to d5efe51 Compare October 24, 2024 09:40
@Standing-Man Standing-Man marked this pull request as ready for review October 24, 2024 09:46
@Standing-Man Standing-Man closed this by deleting the head repository Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:fail CI has failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: replace hardcoding "/tmp/xxx" path
1 participant