Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace hardcoding /tmp/xxx path #1018

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

Standing-Man
Copy link

@Standing-Man Standing-Man commented Nov 4, 2024

Fixed #933.

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

i solved to replace hardcoding about temp directory in some test files to manage temporary test folders automatically.

  • what changes does this pull request make?

I used this cargo to replace many /tmp/xxx temp directory.

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

No need to worry about folder name collision and manage.

@mergify mergify bot requested a review from a team November 4, 2024 07:19
Copy link

mergify bot commented Nov 4, 2024

@JianMinTang Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft November 4, 2024 08:13
@mergify mergify bot added the CI:fail CI has failed label Nov 4, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.12%. Comparing base (e35b35a) to head (87efb60).
Report is 325 commits behind head on master.

Files with missing lines Patch % Lines
crates/xline/src/storage/db.rs 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1018      +/-   ##
==========================================
- Coverage   75.55%   75.12%   -0.44%     
==========================================
  Files         180      190      +10     
  Lines       26938    28483    +1545     
  Branches    26938    28483    +1545     
==========================================
+ Hits        20353    21397    +1044     
- Misses       5366     5783     +417     
- Partials     1219     1303      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot marked this pull request as ready for review November 6, 2024 12:33
@mergify mergify bot removed the CI:fail CI has failed label Nov 6, 2024
Copy link
Collaborator

@bsbds bsbds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@bsbds bsbds merged commit 44b463a into xline-kv:master Nov 8, 2024
16 checks passed
@mergify mergify bot requested a review from a team November 8, 2024 01:45
@Standing-Man Standing-Man deleted the replace-hardcoding branch November 26, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: replace hardcoding "/tmp/xxx" path
2 participants