Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split config to multiple modules #1025

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Standing-Man
Copy link

@Standing-Man Standing-Man commented Nov 18, 2024

fixed #604

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

the configurations are only in single module that doesn't handy to manage.

  • what changes does this pull request make?

i organized these configurations into multiple modules.

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@mergify mergify bot requested a review from a team November 18, 2024 09:06
Copy link

mergify bot commented Nov 18, 2024

@JianMinTang Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft November 18, 2024 09:29
@mergify mergify bot added the CI:fail CI has failed label Nov 18, 2024
@Standing-Man
Copy link
Author

Hi @bsbds, when I use cargo audit to check for dependency vulnerabilities, it suggests that the rustls dependency needs to be updated to a newer version. Would you recommend updating it to the latest version to address potential security issues?

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 82.35753% with 226 lines in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (e35b35a) to head (e8ab1c7).
Report is 332 commits behind head on master.

Files with missing lines Patch % Lines
crates/xline/src/utils/args.rs 0.00% 98 Missing ⚠️
crates/utils/src/config/log.rs 68.11% 17 Missing and 5 partials ⚠️
crates/xlinectl/src/main.rs 0.00% 21 Missing ⚠️
crates/benchmark/src/runner.rs 0.00% 11 Missing ⚠️
crates/curp/src/rpc/reconnect.rs 86.76% 4 Missing and 5 partials ⚠️
crates/utils/src/config/metrics.rs 89.28% 5 Missing and 4 partials ⚠️
crates/utils/src/config/mod.rs 42.85% 7 Missing and 1 partial ⚠️
crates/curp/src/client/unary/mod.rs 44.44% 3 Missing and 2 partials ⚠️
crates/utils/src/config/server.rs 98.76% 1 Missing and 4 partials ⚠️
crates/curp/src/client/retry.rs 0.00% 0 Missing and 4 partials ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
- Coverage   75.55%   75.26%   -0.29%     
==========================================
  Files         180      204      +24     
  Lines       26938    28859    +1921     
  Branches    26938    28859    +1921     
==========================================
+ Hits        20353    21722    +1369     
- Misses       5366     5830     +464     
- Partials     1219     1307      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Standing-Man
Copy link
Author

Standing-Man commented Dec 4, 2024

WIP: refactor new methods to builder pattern! -> Done!

@Standing-Man Standing-Man marked this pull request as ready for review December 10, 2024 04:57
Standing-Man and others added 9 commits December 12, 2024 09:39
Signed-off-by: JianMinTang <[email protected]>

chore: obey clippy rules

Signed-off-by: JianMinTang <[email protected]>

chore: fix needless borrow

Signed-off-by: JianMinTang <[email protected]>

refactor: fix wrong import

Signed-off-by: JianMinTang <[email protected]>

chore: fix fmt format

Signed-off-by: JianMinTang <[email protected]>

chore: change ServerTimeout => XlineServerTimeout

Signed-off-by: JianMinTang <[email protected]>
This PR add the auto reconnect implementation for curp client, as a
workaround for hyperium/tonic#1254.

Signed-off-by: bsbds <[email protected]>
Copy link

mergify bot commented Dec 12, 2024

@Standing-Man You've modified the workflows. Please don't forget to update the .mergify.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI:fail CI has failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor]: config
3 participants