Propose conf change #437

themanforfree · 2023-08-30T15:38:51Z

Please briefly answer these questions:
described in #306
based on #433 ,xline-kv/curp-proto#10

what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
propose config change
what changes does this pull request make?
implement propose_conf_change rpc
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
no

codecov · 2023-08-31T03:09:45Z

Codecov Report

Attention: 308 lines in your changes are missing coverage. Please review.

Comparison is base (ce68124) 53.42% compared to head (2a530df) 52.73%.
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   53.42%   52.73%   -0.70%     
==========================================
  Files         103      104       +1     
  Lines       17763    18156     +393     
  Branches    17763    18156     +393     
==========================================
+ Hits         9490     9574      +84     
- Misses       7706     8011     +305     
- Partials      567      571       +4

Files	Coverage Δ
curp/src/error.rs	`54.96% <ø> (+1.17%)`	⬆️
curp/src/server/raw_curp/state.rs	`93.86% <100.00%> (-0.22%)`	⬇️
curp/src/server/spec_pool.rs	`92.00% <100.00%> (+0.33%)`	⬆️
curp/src/server/storage/db.rs	`67.64% <100.00%> (ø)`
...urp/src/server/cmd_worker/conflict_checked_mpmc.rs	`84.49% <66.66%> (+0.48%)`	⬆️
curp/src/server/gc.rs	`85.21% <93.75%> (-1.10%)`	⬇️
xline/src/server/xline_server.rs	`0.00% <0.00%> (ø)`
curp/src/log_entry.rs	`72.41% <83.33%> (+16.16%)`	⬆️
curp/src/server/raw_curp/tests.rs	`72.22% <94.59%> (+1.51%)`	⬆️
curp/src/members.rs	`83.60% <66.66%> (+2.16%)`	⬆️
... and 9 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

curp/src/rpc/connect.rs

curp/src/server/raw_curp/log.rs

curp/src/server/raw_curp/mod.rs

curp/src/members.rs

curp/src/rpc/connect.rs

curp/src/rpc/mod.rs

curp/src/server/cmd_board.rs

curp/src/server/cmd_worker/mod.rs

curp/src/server/curp_node.rs

curp/src/server/raw_curp/mod.rs

curp/src/server/raw_curp/state.rs

curp/src/server/cmd_board.rs

curp/tests/server.rs

curp/src/server/raw_curp/mod.rs

Phoenix500526

LGTM

curp/src/server/raw_curp/mod.rs

curp/src/server/cmd_worker/mod.rs

Signed-off-by: themanforfree <[email protected]>

fix shutdown and propose_conf_change send to follower Signed-off-by: themanforfree <[email protected]>

Signed-off-by: themanforfree <[email protected]>

return false when set_last_applied failed Signed-off-by: themanforfree <[email protected]>

Signed-off-by: themanforfree <[email protected]>

…yConfig` Signed-off-by: themanforfree <[email protected]>

Signed-off-by: themanforfree <[email protected]>

curp/src/server/cmd_board.rs

curp/src/server/cmd_worker/mod.rs

curp/tests/server.rs

curp/src/server/raw_curp/mod.rs

curp/src/server/raw_curp/log.rs

curp/src/server/cmd_board.rs

curp/src/server/cmd_worker/mod.rs

curp/src/server/raw_curp/mod.rs

curp/src/server/raw_curp/log.rs

curp/src/server/raw_curp/mod.rs

curp/src/server/raw_curp/tests.rs

curp/src/server/gc.rs

Signed-off-by: themanforfree <[email protected]>

Phoenix500526

LGTM

iGxnon

LGTM

themanforfree force-pushed the propose_conf_change branch from bcc7712 to 582079f Compare August 31, 2023 02:57

themanforfree force-pushed the propose_conf_change branch from 582079f to b13c21c Compare September 6, 2023 00:54

themanforfree force-pushed the propose_conf_change branch from b13c21c to a969372 Compare September 13, 2023 05:54

themanforfree mentioned this pull request Sep 14, 2023

Stop removed node and start added node #448

Merged

themanforfree force-pushed the propose_conf_change branch 3 times, most recently from 460e10c to e3b1d46 Compare September 19, 2023 14:38

themanforfree mentioned this pull request Sep 20, 2023

[Feature]: Membership change #306

Closed

4 tasks

themanforfree self-assigned this Sep 21, 2023

themanforfree force-pushed the propose_conf_change branch 4 times, most recently from 88de603 to 7d7bafd Compare September 26, 2023 01:10

themanforfree marked this pull request as ready for review September 26, 2023 01:13

themanforfree force-pushed the propose_conf_change branch 3 times, most recently from 35464d6 to c0636cb Compare September 26, 2023 14:45

rogercloud reviewed Sep 26, 2023

View reviewed changes

curp/src/rpc/connect.rs Outdated Show resolved Hide resolved

curp/src/server/raw_curp/log.rs Outdated Show resolved Hide resolved

curp/src/server/raw_curp/mod.rs Show resolved Hide resolved

iGxnon reviewed Sep 28, 2023

View reviewed changes

bsbds reviewed Sep 28, 2023

View reviewed changes

themanforfree added this to the v0.6.0 milestone Oct 7, 2023

Phoenix500526 requested changes Oct 8, 2023

View reviewed changes

curp/src/server/cmd_board.rs Outdated Show resolved Hide resolved

curp/tests/server.rs Outdated Show resolved Hide resolved

curp/tests/server.rs Show resolved Hide resolved

curp/src/server/raw_curp/mod.rs Show resolved Hide resolved

Phoenix500526 mentioned this pull request Oct 8, 2023

Feat/cluster server #464

Merged

Phoenix500526 reviewed Oct 9, 2023

View reviewed changes

bsbds reviewed Oct 9, 2023

View reviewed changes

curp/src/server/raw_curp/mod.rs Outdated Show resolved Hide resolved

bsbds reviewed Oct 9, 2023

View reviewed changes

curp/src/server/cmd_worker/mod.rs Outdated Show resolved Hide resolved

themanforfree force-pushed the propose_conf_change branch 3 times, most recently from 0a53cf4 to 154a5fa Compare October 9, 2023 08:26

themanforfree force-pushed the propose_conf_change branch from 7e57439 to d81a592 Compare October 11, 2023 08:55

themanforfree added 12 commits October 11, 2023 17:00

feature: implement propose_conf_change rpc

1837c29

Signed-off-by: themanforfree <[email protected]>

refactor: refactor sync logic of curp

159c801

fix shutdown and propose_conf_change send to follower Signed-off-by: themanforfree <[email protected]>

test: add some tests for conf change

086216b

Signed-off-by: themanforfree <[email protected]>

refactor: dedup LogEntry::new and Log::push

09357ed

Signed-off-by: themanforfree <[email protected]>

chore: rename ConnectApiWrapper to InnerConnectApiWrapper

229acb6

Signed-off-by: themanforfree <[email protected]>

chore: rename and update comments

aba1527

return false when set_last_applied failed Signed-off-by: themanforfree <[email protected]>

refactor: remove async of RawCurp::apply_conf_change

0112d94

Signed-off-by: themanforfree <[email protected]>

refactor: remove Deref and DerefMut implementations from `Majorit…

54d51e4

…yConfig` Signed-off-by: themanforfree <[email protected]>

feat: merge fetch leader into fetch cluster

2c4367d

Signed-off-by: themanforfree <[email protected]>

chore: rename tests and fix comments

511c3a0

Signed-off-by: themanforfree <[email protected]>

refactor: dedup handle_xxx

ae02501

Signed-off-by: themanforfree <[email protected]>

chore: update comments and dedup code

28f72c1

Signed-off-by: themanforfree <[email protected]>

themanforfree force-pushed the propose_conf_change branch from d81a592 to a4f9fdc Compare October 11, 2023 09:03

Phoenix500526 reviewed Oct 11, 2023

View reviewed changes

themanforfree force-pushed the propose_conf_change branch from 57d3c7e to ed5629d Compare October 11, 2023 11:23

iGxnon reviewed Oct 11, 2023

View reviewed changes

curp/src/server/cmd_worker/mod.rs Show resolved Hide resolved

curp/src/server/raw_curp/mod.rs Outdated Show resolved Hide resolved

iGxnon reviewed Oct 11, 2023

View reviewed changes

themanforfree added 6 commits October 11, 2023 22:33

refactor: add conf change to spec pool

8659a31

Signed-off-by: themanforfree <[email protected]>

refactor: apply conf change when push to log

1eeb9c6

Signed-off-by: themanforfree <[email protected]>

refactor: fallback conf change if the log is overwritten

368fc44

Signed-off-by: themanforfree <[email protected]>

chore: update comments and remove unecessary codes

12d8df8

Signed-off-by: themanforfree <[email protected]>

chore: update comments

d8bd19a

Signed-off-by: themanforfree <[email protected]>

chore: gc for conf change and fallback indexes

2a530df

Signed-off-by: themanforfree <[email protected]>

themanforfree force-pushed the propose_conf_change branch from b242137 to 2a530df Compare October 11, 2023 15:47

Phoenix500526 approved these changes Oct 12, 2023

View reviewed changes

iGxnon approved these changes Oct 12, 2023

View reviewed changes

Phoenix500526 merged commit 601c710 into xline-kv:master Oct 12, 2023

themanforfree deleted the propose_conf_change branch October 12, 2023 03:19

Phoenix500526 added the enhancement New feature or request label Nov 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Propose conf change #437

Propose conf change #437

themanforfree commented Aug 30, 2023 •

edited

Loading

codecov bot commented Aug 31, 2023 •

edited

Loading

Phoenix500526 left a comment

Phoenix500526 left a comment

iGxnon left a comment

Propose conf change #437

Propose conf change #437

Conversation

themanforfree commented Aug 30, 2023 • edited Loading

codecov bot commented Aug 31, 2023 • edited Loading

Codecov Report

Phoenix500526 left a comment

Choose a reason for hiding this comment

Phoenix500526 left a comment

Choose a reason for hiding this comment

iGxnon left a comment

Choose a reason for hiding this comment

themanforfree commented Aug 30, 2023 •

edited

Loading

codecov bot commented Aug 31, 2023 •

edited

Loading