-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client discover cluster #460
Merged
themanforfree
merged 7 commits into
xline-kv:master
from
themanforfree:mc/cluster-discover-cluster
Oct 24, 2023
Merged
Client discover cluster #460
themanforfree
merged 7 commits into
xline-kv:master
from
themanforfree:mc/cluster-discover-cluster
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themanforfree
force-pushed
the
mc/cluster-discover-cluster
branch
2 times, most recently
from
October 16, 2023 01:46
7c035da
to
ae3ba79
Compare
themanforfree
force-pushed
the
mc/cluster-discover-cluster
branch
from
October 16, 2023 02:26
ae3ba79
to
c62dbbd
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 54.03% 53.73% -0.30%
==========================================
Files 101 101
Lines 17918 18093 +175
Branches 17918 18093 +175
==========================================
+ Hits 9682 9723 +41
- Misses 7659 7793 +134
Partials 577 577
☔ View full report in Codecov by Sentry. |
themanforfree
force-pushed
the
mc/cluster-discover-cluster
branch
2 times, most recently
from
October 16, 2023 09:34
0a9c180
to
9038eb0
Compare
iGxnon
reviewed
Oct 16, 2023
bsbds
reviewed
Oct 17, 2023
themanforfree
force-pushed
the
mc/cluster-discover-cluster
branch
2 times, most recently
from
October 19, 2023 15:33
9a683bd
to
54ec02e
Compare
bsbds
reviewed
Oct 20, 2023
themanforfree
force-pushed
the
mc/cluster-discover-cluster
branch
2 times, most recently
from
October 23, 2023 08:36
e7aeca6
to
253fdb6
Compare
Signed-off-by: themanforfree <[email protected]>
Signed-off-by: themanforfree <[email protected]>
Signed-off-by: themanforfree <[email protected]>
Signed-off-by: themanforfree <[email protected]>
…_state Signed-off-by: themanforfree <[email protected]>
Signed-off-by: themanforfree <[email protected]>
Signed-off-by: themanforfree <[email protected]>
themanforfree
force-pushed
the
mc/cluster-discover-cluster
branch
from
October 23, 2023 12:35
253fdb6
to
de4f2c8
Compare
Phoenix500526
approved these changes
Oct 24, 2023
bsbds
approved these changes
Oct 24, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
described in #306
based on #449
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)