Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client discover cluster #460

Merged

Conversation

themanforfree
Copy link
Collaborator

Please briefly answer these questions:
described in #306
based on #449

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@themanforfree themanforfree changed the title Mc/cluster discover cluster Client discover cluster Sep 26, 2023
@themanforfree themanforfree added this to the v0.6.0 milestone Oct 7, 2023
@themanforfree themanforfree force-pushed the mc/cluster-discover-cluster branch 2 times, most recently from 7c035da to ae3ba79 Compare October 16, 2023 01:46
@themanforfree themanforfree marked this pull request as ready for review October 16, 2023 01:46
@themanforfree themanforfree force-pushed the mc/cluster-discover-cluster branch from ae3ba79 to c62dbbd Compare October 16, 2023 02:26
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 178 lines in your changes are missing coverage. Please review.

Comparison is base (5cee011) 54.03% compared to head (de4f2c8) 53.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   54.03%   53.73%   -0.30%     
==========================================
  Files         101      101              
  Lines       17918    18093     +175     
  Branches    17918    18093     +175     
==========================================
+ Hits         9682     9723      +41     
- Misses       7659     7793     +134     
  Partials      577      577              
Files Coverage Δ
curp/src/error.rs 8.57% <ø> (ø)
curp/src/server/raw_curp/tests.rs 73.93% <ø> (ø)
curp/src/log_entry.rs 80.76% <0.00%> (+8.35%) ⬆️
...urp/src/server/cmd_worker/conflict_checked_mpmc.rs 84.49% <0.00%> (ø)
curp/src/server/cmd_worker/mod.rs 72.41% <0.00%> (ø)
xline/src/server/cluster_server.rs 0.00% <0.00%> (ø)
xline-client/src/error.rs 0.00% <0.00%> (ø)
curp/src/server/raw_curp/mod.rs 67.56% <30.43%> (+0.04%) ⬆️
curp/src/members.rs 76.81% <34.48%> (-4.86%) ⬇️
curp/src/rpc/mod.rs 25.56% <8.00%> (-1.24%) ⬇️
... and 2 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@themanforfree themanforfree force-pushed the mc/cluster-discover-cluster branch 2 times, most recently from 0a9c180 to 9038eb0 Compare October 16, 2023 09:34
curp/src/rpc/mod.rs Outdated Show resolved Hide resolved
curp/src/rpc/mod.rs Outdated Show resolved Hide resolved
curp/src/server/raw_curp/mod.rs Outdated Show resolved Hide resolved
curp/src/members.rs Outdated Show resolved Hide resolved
curp/src/server/raw_curp/mod.rs Show resolved Hide resolved
curp/src/server/curp_node.rs Outdated Show resolved Hide resolved
curp/src/client.rs Outdated Show resolved Hide resolved
curp/src/client.rs Outdated Show resolved Hide resolved
curp/src/client.rs Outdated Show resolved Hide resolved
curp/src/client.rs Outdated Show resolved Hide resolved
curp/src/client.rs Outdated Show resolved Hide resolved
curp/src/server/raw_curp/mod.rs Outdated Show resolved Hide resolved
curp/src/server/curp_node.rs Show resolved Hide resolved
curp/src/server/curp_node.rs Outdated Show resolved Hide resolved
curp/src/members.rs Show resolved Hide resolved
@themanforfree themanforfree force-pushed the mc/cluster-discover-cluster branch 2 times, most recently from 9a683bd to 54ec02e Compare October 19, 2023 15:33
curp/src/client.rs Show resolved Hide resolved
curp/src/client.rs Outdated Show resolved Hide resolved
curp/src/client.rs Outdated Show resolved Hide resolved
@themanforfree themanforfree force-pushed the mc/cluster-discover-cluster branch 2 times, most recently from e7aeca6 to 253fdb6 Compare October 23, 2023 08:36
@themanforfree themanforfree force-pushed the mc/cluster-discover-cluster branch from 253fdb6 to de4f2c8 Compare October 23, 2023 12:35
@themanforfree themanforfree merged commit 2f27a83 into xline-kv:master Oct 24, 2023
16 of 18 checks passed
@themanforfree themanforfree deleted the mc/cluster-discover-cluster branch October 24, 2023 09:27
@themanforfree themanforfree mentioned this pull request Nov 15, 2023
4 tasks
@Phoenix500526 Phoenix500526 added the enhancement New feature or request label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants