Refactor/error handling curp and client #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix500526
force-pushed
the
refactor/error-handling-curp-and-client
branch
2 times, most recently
from
e3cdf34 to
392e2ce
Compare
Phoenix500526
force-pushed
the
refactor/error-handling-curp-and-client
branch
2 times, most recently
from
6b3642d to
385c4d2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 54.23% 54.06% -0.18%
==========================================
Files 101 101
Lines 17872 17918 +46
Branches 17872 17918 +46
==========================================
- Hits 9693 9687 -6
- Misses 7599 7656 +57
+ Partials 580 575 -5
☔ View full report in Codecov by Sentry. |
Phoenix500526
force-pushed
the
refactor/error-handling-curp-and-client
branch
2 times, most recently
from
f3d4c5b to
491b55a
Compare
This was referenced Oct 13, 2023
Phoenix500526
force-pushed
the
refactor/error-handling-curp-and-client
branch
5 times, most recently
from
e6979aa to
7a3ef92
Compare
bsbds
reviewed
Oct 17, 2023
iGxnon
reviewed
Oct 18, 2023
iGxnon
reviewed
Oct 18, 2023
Phoenix500526
force-pushed
the
refactor/error-handling-curp-and-client
branch
2 times, most recently
from
c969695 to
ad2f80e
Compare
Signed-off-by: Phoeniix Zhao <[email protected]>
…ient Refs: xline-kv#463 Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
refactor/error-handling-curp-and-client
branch
3 times, most recently
from
5f05bbf to
6cbd057
Compare
|
Please add a test to cover the conversion between error types and tonic status. |
Phoenix500526
force-pushed
the
refactor/error-handling-curp-and-client
branch
from
a0f5229 to
daec800
Compare
bsbds
approved these changes
Oct 23, 2023
Signed-off-by: Phoeniix Zhao <[email protected]>
…tatus Signed-off-by: Phoeniix Zhao <[email protected]>
Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
refactor/error-handling-curp-and-client
branch
from
331f85f to
0f3f494
Compare
Phoenix500526
added
the
Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
Refactor the error-handling logic in Curp module and its client. FYI: #463
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)