Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add linearizable parameter in FetchClusterRequest #482

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix: add linearizable parameter in FetchClusterRequest #482

merged 1 commit into from
Oct 17, 2023

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Oct 12, 2023

Please briefly answer these questions:

proto changes: xline-kv/curp-proto#14

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

Fix linearizable read in FetchClusterRequest

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (2cbb0fd) 54.13% compared to head (70e0452) 54.12%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   54.13%   54.12%   -0.02%     
==========================================
  Files         101      101              
  Lines       17851    17856       +5     
  Branches    17851    17856       +5     
==========================================
  Hits         9664     9664              
- Misses       7610     7615       +5     
  Partials      577      577              
Files Coverage Δ
xline/src/server/cluster_server.rs 0.00% <0.00%> (ø)
xline/src/server/maintenance.rs 33.33% <0.00%> (ø)
curp/src/server/raw_curp/mod.rs 68.00% <0.00%> (-0.07%) ⬇️
curp/src/server/curp_node.rs 15.30% <0.00%> (-0.06%) ⬇️
curp/src/client.rs 12.80% <0.00%> (-0.29%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iGxnon iGxnon added this to the v0.6.0 milestone Oct 13, 2023
curp/src/client.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iGxnon iGxnon merged commit 452c245 into xline-kv:master Oct 17, 2023
@iGxnon iGxnon deleted the fix/linearizable branch October 17, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants