Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor propose id #483

Merged
merged 2 commits into from
Oct 19, 2023
Merged

refactor: refactor propose id #483

merged 2 commits into from
Oct 19, 2023

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Oct 12, 2023

Please briefly answer these questions:

proto changes: xline-kv/curp-proto#15 xline-kv/xline-proto#5

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    Refactor propose id into ProposeId(u64, u64)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (452c245) 54.12% compared to head (b5ca237) 54.25%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   54.12%   54.25%   +0.13%     
==========================================
  Files         101      101              
  Lines       17856    17872      +16     
  Branches    17856    17872      +16     
==========================================
+ Hits         9664     9697      +33     
+ Misses       7615     7597      -18     
- Partials      577      578       +1     
Files Coverage Δ
curp-test-utils/src/test_cmd.rs 77.81% <100.00%> (ø)
curp/src/log_entry.rs 72.41% <100.00%> (ø)
curp/src/rpc/connect.rs 24.73% <ø> (ø)
curp/src/server/cmd_worker/mod.rs 72.41% <100.00%> (ø)
curp/src/server/gc.rs 85.21% <100.00%> (ø)
curp/src/server/mod.rs 8.93% <100.00%> (ø)
curp/src/server/raw_curp/log.rs 88.44% <100.00%> (ø)
curp/src/server/raw_curp/tests.rs 73.93% <ø> (ø)
curp/src/server/spec_pool.rs 92.00% <100.00%> (ø)
xline/src/server/barriers.rs 77.17% <100.00%> (ø)
... and 9 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

curp/build.rs Show resolved Hide resolved
curp/src/server/cmd_worker/mod.rs Outdated Show resolved Hide resolved
curp/src/server/cmd_worker/mod.rs Show resolved Hide resolved
curp/src/server/curp_node.rs Outdated Show resolved Hide resolved
xline/src/server/barriers.rs Outdated Show resolved Hide resolved
@mergify mergify bot merged commit aa83ea0 into xline-kv:master Oct 19, 2023
18 checks passed
@iGxnon iGxnon deleted the refactor/propose-id branch November 11, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants