Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement xlinectl compaction and member commands #484

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Oct 13, 2023

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4be304b) 52.79% compared to head (32f83ed) 52.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #484      +/-   ##
==========================================
- Coverage   52.79%   52.78%   -0.01%     
==========================================
  Files         104      104              
  Lines       18145    18145              
  Branches    18145    18145              
==========================================
- Hits         9579     9578       -1     
  Misses       7998     7998              
- Partials      568      569       +1     
Files Coverage Δ
xline-client/src/types/kv.rs 0.00% <0.00%> (ø)
xline-client/src/types/cluster.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsbds bsbds added this to the v0.6.0 milestone Oct 13, 2023
@bsbds bsbds marked this pull request as ready for review October 13, 2023 02:57
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iGxnon iGxnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsbds bsbds merged commit 342d83f into xline-kv:master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants