Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix mergify #579

Merged
merged 1 commit into from
Dec 21, 2023
Merged

chore: fix mergify #579

merged 1 commit into from
Dec 21, 2023

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Dec 19, 2023

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    Fix mergify checks

  • what changes does this pull request make?

    As above

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

    No

Signed-off-by: iGxnon <[email protected]>
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa656ad) 64.40% compared to head (9ec3d27) 79.00%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #579       +/-   ##
===========================================
+ Coverage   64.40%   79.00%   +14.60%     
===========================================
  Files         105      154       +49     
  Lines       18802    21284     +2482     
  Branches    18802        0    -18802     
===========================================
+ Hits        12109    16815     +4706     
+ Misses       5955     4469     -1486     
+ Partials      738        0      -738     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@LingKa28 LingKa28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iGxnon iGxnon merged commit 47bcd9f into xline-kv:master Dec 21, 2023
10 checks passed
@iGxnon iGxnon deleted the mergify branch January 10, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants