-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/curp client #581
Refactor/curp client #581
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #581 +/- ##
===========================================
+ Coverage 64.40% 76.97% +12.57%
===========================================
Files 105 156 +51
Lines 18802 21789 +2987
Branches 18802 0 -18802
===========================================
+ Hits 12109 16772 +4663
+ Misses 5955 5017 -938
+ Partials 738 0 -738 ☔ View full report in Codecov by Sentry. |
49950a9
to
c4eec63
Compare
There's a tmp commit message in 8c5313f |
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
764a502
to
a554003
Compare
Reworded |
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Introduce the new client architecture.
what changes does this pull request make?
As above
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No