Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/curp client #581

Merged
merged 6 commits into from
Dec 29, 2023
Merged

Conversation

iGxnon
Copy link
Contributor

@iGxnon iGxnon commented Dec 20, 2023

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    Introduce the new client architecture.

  • what changes does this pull request make?

    As above

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

    No

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 588 lines in your changes are missing coverage. Please review.

Comparison is base (fa656ad) 64.40% compared to head (12b685f) 76.97%.
Report is 27 commits behind head on master.

Files Patch % Lines
curp/src/client_new/unary.rs 0.00% 386 Missing ⚠️
curp/src/rpc/connect.rs 0.00% 76 Missing ⚠️
curp/src/client_new/mod.rs 0.00% 67 Missing ⚠️
xline/src/server/kv_server.rs 21.87% 25 Missing ⚠️
curp/src/rpc/mod.rs 87.27% 7 Missing ⚠️
xline-client/src/clients/kv.rs 78.57% 6 Missing ⚠️
xlineapi/src/command.rs 64.70% 6 Missing ⚠️
xline/src/server/command.rs 70.00% 3 Missing ⚠️
curp/src/client.rs 86.66% 2 Missing ⚠️
curp/src/server/raw_curp/mod.rs 96.82% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #581       +/-   ##
===========================================
+ Coverage   64.40%   76.97%   +12.57%     
===========================================
  Files         105      156       +51     
  Lines       18802    21789     +2987     
  Branches    18802        0    -18802     
===========================================
+ Hits        12109    16772     +4663     
+ Misses       5955     5017      -938     
+ Partials      738        0      -738     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

curp/src/rpc/connect.rs Show resolved Hide resolved
curp/src/client_new/mod.rs Show resolved Hide resolved
curp/src/client_new/mod.rs Show resolved Hide resolved
curp/src/client_new/mod.rs Show resolved Hide resolved
curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
@bsbds
Copy link
Collaborator

bsbds commented Dec 25, 2023

There's a tmp commit message in 8c5313f

@iGxnon iGxnon force-pushed the refactor/curp-client branch from 764a502 to a554003 Compare December 25, 2023 06:10
@iGxnon
Copy link
Contributor Author

iGxnon commented Dec 25, 2023

There's a tmp commit message in 8c5313f

Reworded

curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
curp/src/client_new/unary.rs Outdated Show resolved Hide resolved
curp/src/rpc/connect.rs Show resolved Hide resolved
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phoenix500526 Phoenix500526 merged commit a56b699 into xline-kv:master Dec 29, 2023
8 of 9 checks passed
@iGxnon iGxnon deleted the refactor/curp-client branch January 3, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants