-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: support certificate authentication and add tests #652
Conversation
6b7ce4f
to
e90dbff
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 74.43% 74.69% +0.26%
==========================================
Files 170 171 +1
Lines 24834 25035 +201
Branches 24834 25035 +201
==========================================
+ Hits 18485 18701 +216
+ Misses 5207 5161 -46
- Partials 1142 1173 +31 ☔ View full report in Codecov by Sentry. |
Signed-off-by: themanforfree <[email protected]>
Signed-off-by: themanforfree <[email protected]>
Signed-off-by: themanforfree <[email protected]>
e90dbff
to
c01af08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to add an example in quick start to teach users how to use this feature.
Signed-off-by: themanforfree <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please briefly answer these questions:
based on #648
support certificate authentication and add tests
support certificate authentication and add tests
no