Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: support certificate authentication and add tests #652

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

themanforfree
Copy link
Collaborator

@themanforfree themanforfree commented Feb 8, 2024

Please briefly answer these questions:
based on #648

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    support certificate authentication and add tests
  • what changes does this pull request make?
    support certificate authentication and add tests
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    no

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 74.03315% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 74.69%. Comparing base (6779d42) to head (9ea486b).
Report is 14 commits behind head on master.

Files Patch % Lines
crates/xline-test-utils/src/lib.rs 86.07% 2 Missing and 9 partials ⚠️
crates/xline/src/server/xline_server.rs 69.44% 4 Missing and 7 partials ⚠️
crates/utils/src/lib.rs 0.00% 7 Missing and 1 partial ⚠️
crates/xline/src/server/kv_server.rs 16.66% 3 Missing and 2 partials ⚠️
crates/xline/src/storage/auth_store/store.rs 88.88% 0 Missing and 3 partials ⚠️
crates/xline/src/utils/args.rs 0.00% 3 Missing ⚠️
crates/xline/src/server/lock_server.rs 0.00% 2 Missing ⚠️
crates/xline/src/server/auth_server.rs 0.00% 0 Missing and 1 partial ⚠️
crates/xline/src/server/auth_wrapper.rs 0.00% 0 Missing and 1 partial ⚠️
crates/xline/src/server/lease_server.rs 0.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   74.43%   74.69%   +0.26%     
==========================================
  Files         170      171       +1     
  Lines       24834    25035     +201     
  Branches    24834    25035     +201     
==========================================
+ Hits        18485    18701     +216     
+ Misses       5207     5161      -46     
- Partials     1142     1173      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add an example in quick start to teach users how to use this feature.

crates/utils/src/config.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themanforfree themanforfree merged commit 0709eea into xline-kv:master Mar 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants