-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add bench ci for pr #654
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 75.55% 75.50% -0.05%
==========================================
Files 180 186 +6
Lines 26938 27488 +550
Branches 26938 27488 +550
==========================================
+ Hits 20353 20756 +403
- Misses 5366 5459 +93
- Partials 1219 1273 +54 ☔ View full report in Codecov by Sentry. |
eb73608
to
a91ff88
Compare
cf13f23
to
210a119
Compare
@iGxnon Your PR is in conflict and cannot be merged. |
@iGxnon You've modified the workflows. Please don't forget to update the .mergify.yml. |
scripts/benchmark.sh
Outdated
@@ -127,7 +131,7 @@ stop_all() { | |||
for name in "node1" "node2" "node3" "client"; do | |||
docker_id=$(docker ps -qf "name=${name}") | |||
if [ -n "$docker_id" ]; then | |||
docker stop $docker_id | |||
docker stop $docker_id -t 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you wait 1 second before killing the container?
cat out_local/xline.txt >> bench_outputs | ||
echo "\`\`\`" >> bench_outputs | ||
|
||
# echo -e "\r\n### Base \r\n\`\`\`txt" >> bench_outputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these commentted lines required after 0.7.0?
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon [email protected]
Example: iGxnon#2
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Add benchmark CI for each PR which labeled
run-benchmark
what changes does this pull request make?
As above
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No