Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bytes affine #667

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Feb 29, 2024

Based on: #656

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    Adds a new type BytesAffine, which defines the order of the keys.
    FYI:

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@bsbds bsbds marked this pull request as ready for review February 29, 2024 08:59
@bsbds bsbds force-pushed the add-bytes-affine branch from 479fcee to c5eab91 Compare March 5, 2024 09:55
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 75.07%. Comparing base (40763a8) to head (57bea08).
Report is 10 commits behind head on master.

Files Patch % Lines
crates/xlineapi/src/interval.rs 79.59% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage   75.18%   75.07%   -0.11%     
==========================================
  Files         175      176       +1     
  Lines       26793    26852      +59     
  Branches    26793    26852      +59     
==========================================
+ Hits        20144    20160      +16     
- Misses       5437     5479      +42     
- Partials     1212     1213       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsbds bsbds force-pushed the add-bytes-affine branch from c5eab91 to 55b8ee0 Compare March 18, 2024 01:59
@bsbds bsbds force-pushed the add-bytes-affine branch from 55b8ee0 to e0fa9dc Compare March 22, 2024 09:57
@bsbds bsbds force-pushed the add-bytes-affine branch from daf09ff to 57bea08 Compare March 27, 2024 07:12
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,please squash these commits into one. We should remove the KeyRange in the future. Please leave an issue to track.

@Phoenix500526 Phoenix500526 merged commit 4aab669 into xline-kv:master Mar 28, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants