-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add bytes affine #667
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #667 +/- ##
==========================================
- Coverage 75.18% 75.07% -0.11%
==========================================
Files 175 176 +1
Lines 26793 26852 +59
Branches 26793 26852 +59
==========================================
+ Hits 20144 20160 +16
- Misses 5437 5479 +42
- Partials 1212 1213 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,please squash these commits into one. We should remove the KeyRange
in the future. Please leave an issue to track.
Based on: #656
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Adds a new type
BytesAffine
, which defines the order of the keys.FYI:
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)