Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client)!: Remove request wrappers - AuthClient::user_delete #888

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

lxl66566
Copy link
Collaborator

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

    • change user_delete(&self, request: AuthUserDeleteRequest) to user_delete(&self, name: impl Into<String>)
    • remove types::AuthUserDeleteRequest
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

    • yes, it's a breaking change and may break code uses old version of user_delete().

@mergify mergify bot requested a review from a team July 14, 2024 08:25
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.08%. Comparing base (e35b35a) to head (05faf5a).
Report is 166 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   75.55%   76.08%   +0.53%     
==========================================
  Files         180      189       +9     
  Lines       26938    28811    +1873     
  Branches    26938    28811    +1873     
==========================================
+ Hits        20353    21922    +1569     
- Misses       5366     5555     +189     
- Partials     1219     1334     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lxl66566 lxl66566 force-pushed the refactor-client-user-delete branch from dcf15fa to 05faf5a Compare July 30, 2024 13:31
Copy link

mergify bot commented Jul 30, 2024

@lxl66566 Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft July 30, 2024 13:38
@mergify mergify bot added the CI:fail CI has failed label Jul 30, 2024
@mergify mergify bot marked this pull request as ready for review July 30, 2024 13:45
@mergify mergify bot removed the CI:fail CI has failed label Jul 30, 2024
@mergify mergify bot requested a review from a team July 31, 2024 00:02
@lxl66566 lxl66566 merged commit 0658707 into xline-kv:master Jul 31, 2024
16 checks passed
@lxl66566 lxl66566 deleted the refactor-client-user-delete branch July 31, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants