Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client)!: Remove request wrappers - AuthClient::role_get #895

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

lxl66566
Copy link
Collaborator

Depends-On: #882

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@mergify mergify bot requested a review from a team July 16, 2024 02:08
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.21%. Comparing base (e35b35a) to head (61c82f5).
Report is 171 commits behind head on master.

Files Patch % Lines
crates/xlinectl/src/command/user/get.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
+ Coverage   75.55%   76.21%   +0.66%     
==========================================
  Files         180      189       +9     
  Lines       26938    28809    +1871     
  Branches    26938    28809    +1871     
==========================================
+ Hits        20353    21958    +1605     
- Misses       5366     5522     +156     
- Partials     1219     1329     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

mergify bot commented Jul 30, 2024

@lxl66566 Your PR is in conflict and cannot be merged.

LucienY01
LucienY01 previously approved these changes Aug 1, 2024
@mergify mergify bot requested a review from a team August 1, 2024 07:35
@lxl66566
Copy link
Collaborator Author

lxl66566 commented Aug 1, 2024

rebased

Copy link

mergify bot commented Aug 1, 2024

@lxl66566 Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft August 1, 2024 13:01
@mergify mergify bot added the CI:fail CI has failed label Aug 1, 2024
@lxl66566
Copy link
Collaborator Author

lxl66566 commented Aug 1, 2024

I don't know why this CI continues to fail without any error message. I tested on my machine and there's no error.
edit: now it passed the test.

@mergify mergify bot marked this pull request as ready for review August 2, 2024 00:44
@mergify mergify bot removed the CI:fail CI has failed label Aug 2, 2024
@lxl66566 lxl66566 requested a review from LucienY01 August 2, 2024 00:46
@mergify mergify bot requested a review from a team August 2, 2024 01:17
@lxl66566 lxl66566 merged commit 8a56100 into xline-kv:master Aug 2, 2024
16 checks passed
@lxl66566 lxl66566 deleted the refactor-client-role-get branch August 2, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants