-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(client)!: Remove request wrappers - AuthClient::role_get #895
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #895 +/- ##
==========================================
+ Coverage 75.55% 76.21% +0.66%
==========================================
Files 180 189 +9
Lines 26938 28809 +1871
Branches 26938 28809 +1871
==========================================
+ Hits 20353 21958 +1605
- Misses 5366 5522 +156
- Partials 1219 1329 +110 ☔ View full report in Codecov by Sentry. |
06facb1
to
9479918
Compare
@lxl66566 Your PR is in conflict and cannot be merged. |
Signed-off-by: lxl66566 <[email protected]>
9479918
to
61c82f5
Compare
rebased |
@lxl66566 Convert your pr to draft since CI failed |
I don't know why this CI continues to fail without any error message. I tested on my machine and there's no error. |
Depends-On: #882
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)