Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client)!: Remove request wrappers - AuthClient::role_grant_permission #898

Merged

Conversation

lxl66566
Copy link
Collaborator

Depends-On: #882

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@mergify mergify bot requested a review from a team July 18, 2024 00:45
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 89.04110% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.21%. Comparing base (e35b35a) to head (a98d199).
Report is 187 commits behind head on master.

Files Patch % Lines
crates/xlinectl/src/command/role/grant_perm.rs 79.31% 6 Missing ⚠️
crates/xline-client/src/types/auth.rs 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
+ Coverage   75.55%   76.21%   +0.65%     
==========================================
  Files         180      190      +10     
  Lines       26938    28829    +1891     
  Branches    26938    28829    +1891     
==========================================
+ Hits        20353    21972    +1619     
- Misses       5366     5540     +174     
- Partials     1219     1317      +98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

mergify bot commented Jul 18, 2024

@lxl66566 Your PR is in conflict and cannot be merged.

@mergify mergify bot requested a review from a team August 1, 2024 01:39
@lxl66566 lxl66566 force-pushed the refactor-client-role-grant-permission branch from 78d4f9f to e4151fe Compare August 2, 2024 05:44
@lxl66566 lxl66566 force-pushed the refactor-client-role-grant-permission branch from e4151fe to a98d199 Compare August 2, 2024 07:51
@lxl66566 lxl66566 requested a review from bsbds August 8, 2024 08:29
@mergify mergify bot requested a review from a team August 15, 2024 03:12
@lxl66566 lxl66566 merged commit 62088fc into xline-kv:master Aug 15, 2024
16 checks passed
@lxl66566 lxl66566 deleted the refactor-client-role-grant-permission branch August 15, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants