fix: tests in v0.7 branch #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbds
force-pushed
the
fix-tests
branch
2 times, most recently
from
39dc0fa to
713fefe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor-v0.7.0-new #954 +/- ##
======================================================
Coverage ? 75.51%
======================================================
Files ? 190
Lines ? 29291
Branches ? 29291
======================================================
Hits ? 22120
Misses ? 5847
Partials ? 1324 ☔ View full report in Codecov by Sentry. |
|
@bsbds Your PR is in conflict and cannot be merged. |
|
@bsbds Your PR is in conflict and cannot be merged. |
Signed-off-by: bsbds <[email protected]>
The E2E failure is caused by a Xline bug that could potentially override the current revision. It has been fixed in #955. |
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]> fix: compaction in madsim Run the compaction task synchronously in madsim, please refer to `compact_bg_task` for the madsim compaction code Signed-off-by: bsbds <[email protected]> fix: not waiting for client id in madsim tests Signed-off-by: bsbds <[email protected]> fix: set leader in simulation xline group Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
… serial execution Signed-off-by: bsbds <[email protected]>
Prevents updating the state early before speculative execution Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Only increments revision number when there's key deleted Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
This check is not necessary, the urls are allowed to be empty before publish Signed-off-by: bsbds <[email protected]>
Because client id may change during retry, the propose id generation must be called for each retry Signed-off-by: bsbds <[email protected]>
|
|
It seems sync wait on a event listener will potentialy cause a deadlock, we will address this in the future. Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #951
This PR fixes various bugs in the new refactor, please refer to commit messages in each commit for more details.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)