Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checker #5

Closed
wants to merge 32 commits into from
Closed

Fix checker #5

wants to merge 32 commits into from

Conversation

lxl66566
Copy link
Collaborator

@lxl66566 lxl66566 commented Sep 25, 2024

Depends-On: #4

The rust-clojure ffi serialization/deserialization has some unexpected behavior:

  • missing : for keytype objects. For example, {:a :b} will be translated to {a b} by org.clojure/data.json. Even if setting :key-fn keyword, the result will still be translated to {:a b}, the keytype is only for keys, not values.
    • cheshire/cheshire has the same performance

What does this PR do:

  • Introduce customized ser/de functions to deal with key types.
  • Introduce a NsRegister to declare namespaces and functions before using raw clojure code
  • other ser/de functions and structures fix
  • add more unittests

Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>

more info in Cargo.toml

Signed-off-by: lxl66566 <[email protected]>

fix doctest

Signed-off-by: lxl66566 <[email protected]>
Signed-off-by: lxl66566 <[email protected]>
@lxl66566 lxl66566 mentioned this pull request Sep 29, 2024
@lxl66566 lxl66566 marked this pull request as draft October 11, 2024 01:04
@lxl66566 lxl66566 closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant