Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error handling #13

Closed
wants to merge 3 commits into from

Conversation

LingKa28
Copy link
Contributor

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Add new feature error handling

  • what changes does this pull request make?

    • add grpc error handling.
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    No.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (897d3d2) 91.46% compared to head (53d53de) 83.78%.

Files Patch % Lines
client/protocol.py 46.36% 90 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   91.46%   83.78%   -7.68%     
==========================================
  Files          18       18              
  Lines        1031     1104      +73     
  Branches       60       83      +23     
==========================================
- Hits          943      925      -18     
- Misses         63      150      +87     
- Partials       25       29       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: LingKa <[email protected]>
@LingKa28 LingKa28 force-pushed the feature/error-handling branch from 14055e2 to 53d53de Compare January 14, 2024 09:07
@LingKa28 LingKa28 closed this Jan 16, 2024
@LingKa28 LingKa28 deleted the feature/error-handling branch January 19, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant