Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gears sender plugin to support active-active kafka clusters #794

Merged
merged 2 commits into from
May 20, 2024

Conversation

holidaymike
Copy link
Collaborator

No description provided.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 26.12%. Comparing base (3810591) to head (907143c).
Report is 35 commits behind head on main.

Files Patch % Lines
pkg/plugins/gears/sender.go 0.00% 69 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #794       +/-   ##
===========================================
- Coverage   42.54%   26.12%   -16.42%     
===========================================
  Files         114      267      +153     
  Lines        9050    18129     +9079     
===========================================
+ Hits         3850     4737      +887     
- Misses       4800    12915     +8115     
- Partials      400      477       +77     
Flag Coverage Δ
unittests 26.12% <0.00%> (-16.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@boriwo boriwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@holidaymike holidaymike merged commit d7e8670 into main May 20, 2024
15 of 18 checks passed
@holidaymike holidaymike deleted the gearsender branch May 20, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants