Update visibility of PermissionPolicy fields #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
commented
Jul 24, 2024
| @@ -7,24 +7,46 @@ | |||
|
|
|||
| import CryptoKit | |||
| import XCTest | |||
| @testable import XMTPiOS | |||
There was a problem hiding this comment.
Created an issue for removing @testable from other tests unless it's explicitly needed. This will help us catch inaccessible fields in the future and keep us from using incorrect fields in tests that arent available to SDK users, like how this test was previously using internal only walletAddress field instead of the public address field.
nplasterer
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction 📟
Purpose ℹ️
Scope 🔭