Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more benchmarks #122 #262

Open
wants to merge 27 commits into
base: cdl
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
32a2231
Refactored bench.rs to use criterion for benchmarks
nchristiann Dec 13, 2024
9a087fd
Almost got it to work
nchristiann Dec 14, 2024
76975db
fixed an oopsie
nchristiann Dec 14, 2024
9b32658
fix compile for obenches
radumarias Dec 14, 2024
155ed0a
Update bug_report.md
radumarias Dec 15, 2024
c01cf63
Update Testing.md
radumarias Dec 15, 2024
51a0784
Update Testing.md
radumarias Dec 15, 2024
e81243c
Update CONTRIBUTING.md
radumarias Dec 15, 2024
0f353a8
Update CONTRIBUTING.md
radumarias Dec 15, 2024
b21a204
Update Testing.md
radumarias Dec 15, 2024
10beb81
Update CONTRIBUTING.md
radumarias Dec 15, 2024
75439a8
Update CONTRIBUTING.md
radumarias Dec 15, 2024
7406975
Update Testing.md
radumarias Dec 15, 2024
4a68590
Update Testing.md
radumarias Dec 15, 2024
76be083
Update Testing.md
radumarias Dec 15, 2024
8285fc9
Update CONTRIBUTING.md
radumarias Dec 15, 2024
262f56d
Update bug_report.md
radumarias Dec 15, 2024
19e0390
Add files via upload
radumarias Dec 15, 2024
0cfeeef
Update CONTRIBUTING.md
radumarias Dec 15, 2024
5b4ead0
Update CONTRIBUTING.md
radumarias Dec 16, 2024
b6381f4
[#122] Create utils for running bench with criterion that uses fs and…
radumarias Dec 16, 2024
c894117
Merge branch 'main' into testing
radumarias Dec 16, 2024
ae65de4
Update build_and_tests_reusable.yaml
radumarias Dec 16, 2024
b92ed63
add bench to check-before-push but commented out
radumarias Dec 16, 2024
e3ccedb
Update build_and_tests_reusable.yaml
radumarias Dec 16, 2024
b9f18d1
clippy
radumarias Dec 16, 2024
198febc
Merge branch 'main' into testing
radumarias Dec 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,16 @@ Steps to reproduce the behavior:
4. See error

**Actual behavior**
A clear and concise description of what you exaclty is happening.

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.
**Screenshots or screen recordings**
If applicable, add screenshots or screen recordings to help explain your problem.

**Logs**
Collectt last 100 lines from terminal and attach those to the issue.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
Expand Down
24 changes: 17 additions & 7 deletions .github/workflows/build_and_tests_reusable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,17 @@ jobs:
-A clippy::type_complexity
shell: bash

- name: doc
run: cargo doc --workspace --all-features --no-deps

- name: tests
if: matrix.os != 'windows-latest'
run: cargo test --release --all --all-features -- --skip keyring

- name: bench
if: matrix.os != 'windows-latest'
run: cargo bench --workspace --all-targets --all-features -- --skip keyring

- name: doc
run: cargo doc --workspace --all-features --no-deps

- name: test package
if: matrix.os == 'ubuntu-latest'
run: |
Expand Down Expand Up @@ -92,13 +96,19 @@ jobs:
-A clippy::type_complexity
shell: bash

- name: java-bridge doc
- name: java-bridge tests
if: matrix.os != 'windows-latest'
run: |
cd java-bridge
cargo doc --workspace --all-features --no-deps
cargo test --release --all --all-features

- name: java-bridge tests
- name: java-bridge bench
if: matrix.os != 'windows-latest'
run: |
cd java-bridge
cargo test --release --all --all-features
cargo bench --workspace --all-targets --all-features

- name: java-bridge doc
run: |
cd java-bridge
cargo doc --workspace --all-features --no-deps
1 change: 1 addition & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 11 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,17 @@ defined in the Apache License shall be dual-licensed as above, without any addit
with `chmod +x .git/hooks/pre-push` .This will run when you do `git push` and will make the push quite
slow, but please give it time to complete as this helps to fix any issues locally and not rely just on
running `ci` on GitHub when you create the PR
13. Commit and push your changes, and if there are any errors, fix them before you push them
14. Create a `PR` back to the `parent` repo targeting the `main` branch and request review from
owners of the repository by adding them to the `Reviewers` field
15. In the project, move the item to `In Code Review`
16. Monitor the checks (GitHub actions runs) and fix the code if they are failing
17. Respond to any comments
18. **DON'T MERGE THE PR YOURSELF. LEAVE THAT TO REPOSITORY OWNERS**
19. In the end, ideally, it will be merged into `main`
13. Commit the changes with the commit message following the [Commit Message Guidelines](https://gist.github.com/radumarias/5b5374f3ed022c99d617eb849aafd069)
14. Push your changes, and if there are any errors, fix them before you push them
15. Create a `PR` back to the `parent` repo targeting the `main` branch with the title as the GitHub issue title, including `#ID`. Also, include the link to the GitHub issue in the description, saying like `Fix for <link>` for bugs or `Implementation for <link>` for features and others
16. Request review from owners of the repository by adding them to the `Reviewers` field
17. After you create the PR, link it to the GH issue from the mid-right of the page, press the gear icon from the below image, select `radumarias/rencfs`, then write the issue number and select it. This will link the two, and when the PR is merged, it will close the issue too
![image](https://github.com/user-attachments/assets/5ac0313d-4175-44d1-8d1e-d18da773ab32)
18. In the project, move the item to `In Code Review`
19. Monitor the checks (GitHub actions runs) and fix the code if they are failing
20. Respond to any comments
21. **DON'T MERGE THE PR YOURSELF. LEAVE THAT TO REPOSITORY OWNERS**
22. In the end, ideally, it will be merged into `main`

# QA manual

Expand Down
Loading