More complete Multipole Rotations and Shifts within solenoid elements #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
October 31, 2024 10:21
Twiss and survey with madpoint Comparison plotting
Parameter name change to 'transform' to avoid confusion with element rotations
Handling of XYSRotations Renaming of variables
Cleanup of structure for troubleshooting ease
Increased clarity now that there are many more parameters to keep track of
Tests vertical and horizontal reference frame shifts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In addition to the existing multi_shift_x and mult_rot_y, the rest of the transformations have been added for the solenoid.
Done to allow for SuperKEKB IR modelling.
Changes the solenoid C++ code and definition to allow for these parameters
Added tests in the example, not fully written as test as awaiting feedback
Change to allowing rotations within the environment building tool not fully tested, but used for examples.
Closes # .
Checklist
Mandatory:
Optional: