feat: update var names #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -3,7 +3,7 @@ import { Reviewer } from './reviewer'; | |||
| import { Options as Config } from './options'; | |||
| import { cliCanRun } from './utils'; | |||
|
|
|||
There was a problem hiding this comment.
The variable name 'o' is not descriptive. Consider using a more descriptive name for the type, such as 'CliOptions'.
| @@ -20,7 +20,7 @@ type CliOptions = { | |||
| .requiredOption('-r, --repository <string>', 'Repository name to review') | |||
| .requiredOption('-o, --owner <string>', 'Repository owner') | |||
| .addOption(new Option('-m, --model <string>', 'OpenAI GPT model to use').choices(['gpt-3.5-turbo', 'gpt-4']).makeOptionMandatory(true)) | |||
There was a problem hiding this comment.
The variable name 'o' is not descriptive. Consider using a more descriptive name for the type, such as 'CliOptions'.
| @@ -3,16 +3,16 @@ export const SUPPORTED_ACTIONS = ['opened', 'labeled']; | |||
| export const SUPPORTED_FILE_EXTENSIONS = ['.js', '.ts', '.py', '.java']; | |||
|
|
|||
| export class Options { | |||
There was a problem hiding this comment.
The variable names 'openai_Api_Key' and 'openai_Api_Base_Url' do not follow the camelCase naming convention typically used in JavaScript. Consider renaming them to 'openaiApiKey' and 'openaiApiBaseUrl' respectively.
| @@ -29,7 +29,7 @@ export class Reviewer { | |||
|
|
|||
| constructor(options: Options) { | |||
| this.options = options; | |||
| const model = createOpenAILanguageModel(options.openaiApiKey, options.openaiModel); | |||
| const model = createOpenAILanguageModel(options.openai_Api_Key, options.openaiModel); | |||
There was a problem hiding this comment.
The variable name 'openai_Api_Key' does not follow the camelCase naming convention. Consider renaming it to 'openaiApiKey'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.