Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added black and white lists. Changed interval for statistics #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nmisha
Copy link

@nmisha nmisha commented Feb 26, 2025

  1. Added black and white lists for adguard
  2. Some lists temporary disabled
  3. Changed interval for statistics
  4. 'cloud.mikrotik.com' excluded from statistics

@xtrime-ru
Copy link
Owner

xtrime-ru commented Feb 26, 2025

This looks like personal settings and im not sure it should be enabled by default for all users. You can edit settings in admin panel and they will persist during updates.

I dont want to use many adblock lists by default. Phishing/malware - ok. I personally against of filtering ads, because it is revenue for content creators and site owners.

And what is the purpose of adding 'cloud.mikrotik.com' in config and extending statistic interval?

@nmisha
Copy link
Author

nmisha commented Feb 26, 2025

This looks like personal settings and im not sure it should be enabled by default for all users. You can edit settings in admin panel and they will persist during updates.

I dont want to use many adblock lists by default. Phishing/malware - ok. I personally against of filtering ads, because it is revenue for content creators and site owners.

The position is clear, it’s fair

And what is the purpose of adding 'cloud.mikrotik.com' in config and extending statistic interval?

Mikrotik requests this address too often. Once every couple of seconds. This is how it understands that the Internet is online. These requests clutter up the statistics, making it unreadable without an address exclusion filter

@nmisha
Copy link
Author

nmisha commented Feb 26, 2025

  1. Kept default agh lists with default enable/disable state
  2. Removed custom ad lists
  3. Kept phishing, malware, crypto miners in browser, etc lists
  4. Kept white lists. For cases of any errors in blacklists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants