XWIKI-13987: Navbar height is increased by 5px on small device (<768px) #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the space used by the left navbar when it has no children (xwiki standard's default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-13987
Changes
Description
Clarification
I decided to be extra precise with the selector to not degrade the state of the navbar-left elements when there's some inside. I didn't test in this case, but the selector should avoid that this change have any unexpected effects.
Screenshots & Video
The screens for the state before the PR are on the ticket itself.
Here is what this UI looks like with the changes proposed in this PR:
2024-11-21.16-09-54.mp4
We can see that there's not a middle step anymore. The only two states of the navbar are: everything on one line, icon on one line and actions on the next one.
Executed Tests
Manual tests for style changes. See the video above.
Expected merging strategy
Assignee
Assigning surli since he already heard of this issue :)