XWIKI-22680: Regression on createAndDeleteUser

[Sereza7]

Jira URL

https://jira.xwiki.org/browse/XWIKI-22680

Fix for the CI regressions: https://ci.xwiki.org/job/XWiki/job/xwiki-platform/job/stable-16.10.x/9/testReport/junit/org.xwiki.invitation.test.docker/AllIT$NestedInvitationIT/Platform_Builds___main___integration_tests___IT_for_xwiki_platform_core_xwiki_platform_invitation_xwiki_platform_invitation_test_xwiki_platform_invitation_test_docker___Build_for_IT_for_xwiki_platform_core_xwiki_platform_invitation_xwiki_platform_invitation_test_xwiki_platform_invitation_test_docker___nonAdminCanSend_TestUtils_/ and https://ci.xwiki.org/job/XWiki/job/xwiki-platform/job/stable-16.10.x/lastCompletedBuild/testReport/org.xwiki.invitation.test.docker/AllIT$NestedInvitationIT/Platform_Builds___main___integration_tests___IT_for_xwiki_platform_core_xwiki_platform_invitation_xwiki_platform_invitation_test_xwiki_platform_invitation_test_docker___Build_for_IT_for_xwiki_platform_core_xwiki_platform_invitation_xwiki_platform_invitation_test_xwiki_platform_invitation_test_docker___guestActionsOnNonexistantMessage_TestUtils_/

Changes

Description

• Removed the waiting for forms that do not use livevalidation.

Clarifications

• I failed to consider those forms before. Thanks to luck, the conditions to wait did not influence the invitation form. However, with the latest merge, the condition were not enough. In order to solve this, I used the presence of a validation message to check if the form relied on the livevalidation script. Without this validation message, there is no need for a wait because there's nothing stopping the form from being submitted.

Screenshots & Video

None, test only change.

Executed Tests

After building the changes with mvn clean install -f xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui, I could pass the tests locally: mvn clean install -f xwiki-platform-core/xwiki-platform-invitation/xwiki-platform-invitation-test/xwiki-platform-invitation-test-docker -Dit.test=InvitationIT#guestActionsOnNonexistantMessage and mvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker -Dit.test=RegisterIT#registerExistingUser.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • 16.10.X, similar to XWIKI-22680: Regression on createAndDeleteUser #3675