Mega-Combo-PR. Fixed some typos, and some exceptions. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found typos using NetBeans IDE. Then squashed two other clean-up check-ins. Possibly okay? Remove extraneous file
I *believe* currentTarget.id is the id that is relevant to scrolling in this context.
Bodhi was not getting a gettargetableunits prototype with a .vanilla member, because while wrap_after adds a .vanilla to /his/ gettargetableunits, it does not modify the Unit.prototype.gettargetableunits. Also, the call needs to include the unit from which to measure, not the list of valid targets itself.
Activeweapon is not a member of this, m, n, or d. This.weapon.unit / this has an activeweapon member but in this context it's set to -1, which would probably cause an out of range exception too. But each weapon has the .isactive member which, at least in this case, is true. So this seems like a safe way to select a valid active weapon for Alliance Overhaul-equipped ARC-170s.
Sleet01
changed the title
…he log Updated Latts Razzi crew card to output stress source, Evade benificiary, and Latts' name, instead of the entirety of the Latts Razzi card and then Latts' name.
…t into the log" This reverts commit a8b27d9.
Latts Razzi crew card was printing its entire contents into the log window, rather than just its name. Also, it did not indicate which card it was pulling the stress from. This fix alleviates both problems.
I was holding off on checking in the compiled version, so that the XWS-Bench repo could import my changes without immediately changing the hosted code itself. But I eventually decided to check in the compiled, minified code so that people can test my changes for themselves, via my cloned repo.
Several calls were wrong. Note: Snapshot still does not work correctly.
xws-bench
pushed a commit
that referenced
this pull request
Apr 7, 2018
Laser -> Turretlaser should be sufficient for this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found typos using NetBeans IDE.
Then squashed some other clean-up check-ins.