fix: restrict construction_order when searching for node callbacks #4

xygyo77 · 2024-02-21T13:41:14Z

Description

restrict construction_order when searching for node callbacks

Notes for reviewers

Pre-review checklist for the PR author

I've confirmed the contribution guidelines.
The PR is ready for review.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR has been properly tested.
The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

(Optional) The PR has been properly tested with CARET_report verification.
There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

* latency does not convert sim_time Signed-off-by: ISP akm <[email protected]> * Response_time does not convert sim_time Signed-off-by: ISP akm <[email protected]> * To pass pytest Signed-off-by: ISP akm <[email protected]> * Fix for pytest Signed-off-by: ISP akm <[email protected]> * Fixed X axis to sim_time conversion in staced_bar's to_dataframe(). Signed-off-by: ISP akm <[email protected]> * ci(pre-commit): autofix * Added xaxis_type to the to_stacked_bar_data() argument. Signed-off-by: ISP akm <[email protected]> * ci(pre-commit): autofix * Added xaxis_type to the to_stacked_bar_data() argument. Signed-off-by: ISP akm <[email protected]> * fixed argument error passed to _find_node_path (tier4#453) * pytest support Signed-off-by: ISP akm <[email protected]> --------- Signed-off-by: ISP akm <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: miyakoshi <[email protected]>

Signed-off-by: h-suzuki <[email protected]>

* fix: erase old implementation of response time histogram Signed-off-by: rokamu623 <[email protected]> * fix: erase unused old histogam and timeseries in response_time Signed-off-by: rokamu623 <[email protected]> --------- Signed-off-by: rokamu623 <[email protected]>

updates: - [github.com/pre-commit/mirrors-prettier: v4.0.0-alpha.4 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v4.0.0-alpha.4...v4.0.0-alpha.8) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Signed-off-by: ymski <[email protected]>

* Fixed doc_string in CallbackStructValue. Signed-off-by: emb4 <[email protected]> * Fixed doc_string in CallbackValue. Signed-off-by: emb4 <[email protected]> * Fixed doc_string in ExecutorStructValue. Signed-off-by: emb4 <[email protected]> * Corrected the beginning of the sentence in doc_string to be capitalized. Signed-off-by: emb4 <[email protected]> * Periods were added to doc_string. Signed-off-by: emb4 <[email protected]> * Fixed according to doc_string rules. Signed-off-by: emb4 <[email protected]> * Fixed mypy error. Signed-off-by: emb4 <[email protected]> * docs: fill lacked doc string Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string of NodePathValue Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string of NodeValue Signed-off-by: rokamu623 <[email protected]> * docs: dill doc string of NodeValueWithId Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string in NodeStructValue Signed-off-by: rokamu623 <[email protected]> * fix: minor mistake Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string of DiffNode Signed-off-by: rokamu623 <[email protected]> * docs: fix argument Signed-off-by: rokamu623 <[email protected]> * Fixed doc_string in ExecutorType. Signed-off-by: emb4 <[email protected]> * Fixed according to doc_string rules. Signed-off-by: emb4 <[email protected]> * Spelling corrected.. Signed-off-by: emb4 <[email protected]> * Fixed underbar Signed-off-by: emb4 <[email protected]> * docs: fill doc string of ServiceCallbackValue Signed-off-by: rokamu623 <[email protected]> * docs: doc string of ServiceCallbackStructValue Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string of ServiceValue Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string of ServiceStructValue Signed-off-by: rokamu623 <[email protected]> * Fixed initials and periods in doc_string. Signed-off-by: emb4 <[email protected]> * Fixed doc_string in ExecutorValue. Signed-off-by: emb4 <[email protected]> * Fixed return anotation. Signed-off-by: emb4 <[email protected]> * Fixed return anotation. Signed-off-by: emb4 <[email protected]> * docs: fill doc string of SubscriptionCallbackStructValue Signed-off-by: rokamu623 <[email protected]> * docs: fix minor mistake in CallbackValue Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string of SubscriptionCallbackValue Signed-off-by: rokamu623 <[email protected]> * Fixed spell. Signed-off-by: emb4 <[email protected]> * Fixed spell. Signed-off-by: emb4 <[email protected]> * docs: fix minor mistake Signed-off-by: rokamu623 <[email protected]> * docs: fix minor mistake in CallbackValue Signed-off-by: rokamu623 <[email protected]> * docs: fix type mistake Signed-off-by: rokamu623 <[email protected]> * docs: fix minor mistake Signed-off-by: rokamu623 <[email protected]> * docs: add __init__ doc string Signed-off-by: rokamu623 <[email protected]> * docs: fix upper case lacking Signed-off-by: rokamu623 <[email protected]> * docs: fix pep Signed-off-by: rokamu623 <[email protected]> * docs: fix upper case Signed-off-by: rokamu623 <[email protected]> * docs: fix spell Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string of SubscriptionValue Signed-off-by: rokamu623 <[email protected]> * docs: fix return type Signed-off-by: rokamu623 <[email protected]> * docs: add __init__ doc string Signed-off-by: rokamu623 <[email protected]> * Changed doc_string Return to Get.. Signed-off-by: emb4 <[email protected]> * docs: fix return type Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string of SubscriptionStructValue Signed-off-by: rokamu623 <[email protected]> * Fixed doc_string in InheritUniqueStamp. Signed-off-by: emb4 <[email protected]> * Fixed doc_string in MessageContext. Signed-off-by: emb4 <[email protected]> * Fixed doc_string in MessageContextType. Signed-off-by: emb4 <[email protected]> * Fixed doc_string in PathValue. Signed-off-by: emb4 <[email protected]> * Grammatical errors were corrected.. Signed-off-by: emb4 <[email protected]> * Corrected omissions. Signed-off-by: emb4 <[email protected]> * Grammatical errors were corrected.. Signed-off-by: emb4 <[email protected]> * Fixed spell miss. Signed-off-by: emb4 <[email protected]> * docs: fix doc string TimerValue Signed-off-by: rokamu623 <[email protected]> * docs: fix doc string TimerStructValue Signed-off-by: rokamu623 <[email protected]> * docs: fix doc string TimerCallbackValue Signed-off-by: rokamu623 <[email protected]> * docs: fix doc string TimerCallbackStructValue Signed-off-by: rokamu623 <[email protected]> * Fixed doc_string in PublisherStructValue. Signed-off-by: emb4 <[email protected]> * Fixed spell miss. Signed-off-by: emb4 <[email protected]> * docs: fix doc string of Tilde (WiP) Signed-off-by: rokamu623 <[email protected]> * docs: fix doc string of VariablePassingValue Signed-off-by: rokamu623 <[email protected]> * docs: fix doc string of VariablePassingStructValue Signed-off-by: rokamu623 <[email protected]> * docs: fix upper case Signed-off-by: rokamu623 <[email protected]> * docs: fix doc string of __init__ lack variable name Signed-off-by: rokamu623 <[email protected]> * docs: fix variable name in doc string in __init__ Signed-off-by: rokamu623 <[email protected]> * Fixed doc_string. Signed-off-by: emb4 <[email protected]> * Fixed doc_string in revision_api_list_publishervalue. Signed-off-by: emb4 <[email protected]> * Corrected wording. Signed-off-by: emb4 <[email protected]> * docs: fix blank line Signed-off-by: rokamu623 <[email protected]> * docs: fix period Signed-off-by: rokamu623 <[email protected]> * docs: fix upper case Signed-off-by: rokamu623 <[email protected]> * docs: fix period Signed-off-by: rokamu623 <[email protected]> * Fixed doc_string in Qos. Signed-off-by: emb4 <[email protected]> * docs: fix doc string of is_applicable_path Signed-off-by: rokamu623 <[email protected]> * docs: fill doc string of UseLatestMessage Signed-off-by: rokamu623 <[email protected]> * Fixed return anotation. Signed-off-by: emb4 <[email protected]> * docs: fix doc string of CallbackStructValue Signed-off-by: rokamu623 <[email protected]> * docs: fix upper case and period Signed-off-by: rokamu623 <[email protected]> * docs: fix upper case and period Signed-off-by: rokamu623 <[email protected]> * docs: fix upper case and period Signed-off-by: rokamu623 <[email protected]> * docs: fix upper case and period Signed-off-by: rokamu623 <[email protected]> * docs: doc string of __str__ Signed-off-by: rokamu623 <[email protected]> * docs: doc string of CallbackType Signed-off-by: rokamu623 <[email protected]> * docs: fix period Signed-off-by: rokamu623 <[email protected]> * minor mistake in publisher Signed-off-by: rokamu623 <[email protected]> --------- Signed-off-by: emb4 <[email protected]> Signed-off-by: rokamu623 <[email protected]> Co-authored-by: emb4 <[email protected]> Co-authored-by: emori-ctc <[email protected]>

Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* diff_node_names Signed-off-by: yu-taro- <[email protected]> * 20230130 Signed-off-by: yu-taro- <[email protected]> * diff_node_names 20230205 * re Signed-off-by: yu-taro- <[email protected]> * class Diff Signed-off-by: yu-taro- <[email protected]> * 20230205 Signed-off-by: yu-taro- <[email protected]> * refactor(arcitecture), test(test_arcitecture) / Naming conventions were changed and mock tests were added and modified because of the points raised Signed-off-by: yu-taro- <[email protected]> * a Signed-off-by: yu-taro- <[email protected]> * conflict fix2 Signed-off-by: yu-taro- <[email protected]> * fix: pytest error Signed-off-by: taro-yu <[email protected]> * refactor: fix plot api annotations about Timeseriestypes Signed-off-by: taro-yu <[email protected]> * refactor: add annotations of publisher and subscription to plot API Signed-off-by: taro-yu <[email protected]> * refactor: fix pytest error Signed-off-by: taro-yu <[email protected]> * docs: fix docs about period and frequency api Signed-off-by: taro-yu <[email protected]> * refactor: add the annotations of Pub and Sub to peri and freq hist plot api Signed-off-by: taro-yu <[email protected]> --------- Signed-off-by: yu-taro- <[email protected]> Signed-off-by: taro-yu <[email protected]> Co-authored-by: taro-yu <[email protected]>

updates: - [github.com/igorshubovych/markdownlint-cli: v0.38.0 → v0.39.0](igorshubovych/markdownlint-cli@v0.38.0...v0.39.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Signed-off-by: ISP akm <[email protected]>

xygyo77 and others added 13 commits December 27, 2023 13:29

feat: improvement of judgement ros distribution (tier4#452)

5cefbfb

Signed-off-by: h-suzuki <[email protected]>

ci(pre-commit): autoupdate (tier4#450)

85e15cb

updates: - [github.com/pre-commit/mirrors-prettier: v4.0.0-alpha.4 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v4.0.0-alpha.4...v4.0.0-alpha.8) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

fix deploy-docs (tier4#462)

2385aec

Signed-off-by: ymski <[email protected]>

ci(pre-commit): autoupdate (tier4#468)

3dff308

updates: - [github.com/igorshubovych/markdownlint-cli: v0.38.0 → v0.39.0](igorshubovych/markdownlint-cli@v0.38.0...v0.39.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

add max_construction_order parameter

a285426

Signed-off-by: ISP akm <[email protected]>

Output callback search restricted node name

0d5479f

Signed-off-by: ISP akm <[email protected]>

Limit callback search by maximum number of construction orders

34b4fc4

Signed-off-by: ISP akm <[email protected]>

If max_construction_order=0, the default value is used.

d3b07f9

Signed-off-by: ISP akm <[email protected]>

xygyo77 changed the title ~~Limit callbacks~~ restrict construction_order when searching for node callbacks Feb 21, 2024

xygyo77 added 2 commits February 22, 2024 14:48

for pytest

763b07c

Signed-off-by: ISP akm <[email protected]>

for pytest

4785d7a

Signed-off-by: ISP akm <[email protected]>

xygyo77 changed the title ~~restrict construction_order when searching for node callbacks~~ fix: restrict construction_order when searching for node callbacks Feb 22, 2024

for pytest

d2e32f8

Signed-off-by: ISP akm <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: restrict construction_order when searching for node callbacks #4

fix: restrict construction_order when searching for node callbacks #4

xygyo77 commented Feb 21, 2024 •

edited

Loading

fix: restrict construction_order when searching for node callbacks #4

Are you sure you want to change the base?

fix: restrict construction_order when searching for node callbacks #4

Conversation

xygyo77 commented Feb 21, 2024 • edited Loading

Description

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

xygyo77 commented Feb 21, 2024 •

edited

Loading