-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tsdocs for everything and improve typings for readability #270
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
eb09da1
Add tsdocs and improve typings for readability
remcoder abd91b1
linting
remcoder 7eae8ca
Some styling
remcoder 3837c3b
Merge branch 'develop' into feature/document-parser-api
remcoder 162d7b8
docs: add JSDoc comments to BuildVolume class
remcoder 3d1c7ad
Add TSDoc documentation to dev-gui.ts
remcoder ec20881
Add TSDoc documentation to extrusion-geometry.ts
remcoder 5807b38
Mark gcode-parser.ts as documented
remcoder 800ead1
Add TSDoc documentation to gcode-preview.ts
remcoder d690f58
Add TSDoc documentation to interpreter.ts
remcoder d4fb9d9
Add TSDoc comments to job.ts
remcoder b1dc8d8
Add TSDoc comments to path.ts
remcoder a6f85b0
Add TSDoc comments to thumbnail.ts
remcoder 07e717b
Add TSDoc comments to WebGLPreview class methods
remcoder 450ffce
docs: add TSDoc comments to Grid helper
remcoder 964077b
docs: add TSDoc comments to LineBox helper
remcoder dca9327
docs: add TSDoc comments to three-utils.ts
remcoder db7351e
docs: add TSDoc comments to webgl-preview.ts
remcoder 3283c82
docs: remove duplicate tsdoc comments in dev-gui.ts
remcoder b3d98a4
docs: remove duplicate tsdoc comments in webgl-preview.ts
remcoder 9bf1b83
docs: finalize documentation review and cleanup
remcoder 3d02a9a
docs: improve gcode-parser.ts documentation
remcoder b9c022a
Wording
remcoder d0dfadf
Tweak config
remcoder 82372c1
Cleanup
remcoder ad6ec54
Fix link
remcoder 204fe48
linting
remcoder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
#!/bin/sh | ||
gcloud storage buckets update gs://gcode-preview.firebasestorage.app --cors-file=cors.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[ | ||
{ | ||
"origin": ["*"], | ||
"method": ["GET"], | ||
"responseHeader": ["Content-Type"], | ||
"maxAgeSeconds": 3600 | ||
} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also an inch mode (that does not impact anything really, except some arc support calculations). It is true that it's
mm
by default, but not necessarily.