Update color instantly #275
Conversation
|
Visit the preview URL for this PR (updated for commit ff62254): https://gcode-preview--pr275-poc-instant-color-ch-6qh01fy5.web.app (expires Thu, 13 Feb 2025 21:43:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531 |
- Added y-axis clipping support to shaders - Simplified clipping implementation using y values - Removed old Plane-based clipping system - Fixed material initialization and uniform access - Cleaned up all references to old implementation
- Added y-axis clipping for ShaderMaterial (tubes) - Restored plane-based clipping for LineMaterial (travel lines) - Added updateLineClipping method to sync both systems - Cleaned up imports and removed duplicates
# Conflicts: # src/dev-gui.ts # src/webgl-preview.ts
| render.add(this.watchedObject.renderer.info.memory, 'geometries').listen(); | ||
| render.add(this.watchedObject.renderer.info.memory, 'textures').listen(); | ||
| render.add(this.watchedObject, '_lastRenderTime').listen(); | ||
| render.add(this.webglPreview.renderer.info.render, 'triangles').listen(); |
There was a problem hiding this comment.
Be careful with changing watchedObject. I had issues with this referencing some old objects when they are replaced.
We have many this.an_object = new ObjectClass() that made it a challenge to watch on the GUI.
There was a problem hiding this comment.
Thanks for the heads-up. I doublechecked and I don't think this changes breaks anything. The watchedObject is still the same instance but now it is typed to make the compiler happy.
There was a problem hiding this comment.
Have you checked with the other places where watchedObject is changed too?
There was a problem hiding this comment.
I'll check it again! Will try tomorrow.
There was a problem hiding this comment.
I checked all the dev helpers. Nothing is broken by this PR.
The Job info and _lastRenderTime don't update but I checked that was already the case be for this PR.
Only the types have changed and the namei of the instance but there shouldn't be even a change in the javascript code that is being generated.
btw, did you see you can now change the lighting through the dev helper?
This is an improvement to change the color of the model instantly, without having to rebuild the mesh.
It uses a simple ShaderMaterial which has an updatable uniform property for the color. Updating this doesn't require rebuilding the mesh, it only requires a renderer.render call.
It actually works better than expected so I promoted this from poc to pr.
TODO
fix drag n dropseparate issue Detect number of colors/tools when dropping a file #277I needed a good model to test shader with so I included Marlin (by cipis)
It looks great with this shader!