Fix Nested Map Column Type Parsing Bug #336
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xzkostyan
Hello! It's my first pull request.
I want to fix bug for Nested Map columns.
I'm currently using a datahub, and I think modifying the code will make the column types visible
Please feel free to review the changes and provide any feedback or suggestions for improvement.
related datahub issue is datahub-project/datahub#9079
Test Table DDL
Before Edit
![image](https://private-user-images.githubusercontent.com/54092915/365425227-137dfff8-0a8b-42ac-bdeb-c19de1c895f4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTk0MTksIm5iZiI6MTczOTE5OTExOSwicGF0aCI6Ii81NDA5MjkxNS8zNjU0MjUyMjctMTM3ZGZmZjgtMGE4Yi00MmFjLWJkZWItYzE5ZGUxYzg5NWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE0NTE1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUzMzI1MTUyYTI2ZTcwMmI4YWQ1ZmY4NzFhMTdmMzE0MTk5YzgyNWNlMGM2ZDA5ODM1YTJmZjIyNWZjNjVjZDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.4qzzwzEKqx1Oz36TblGrLkrZvFFKcgf2s3RhF3Sphjs)
TypeError: Map.__init__() missing 1 required positional argument: 'value_type'
After Edit
![image](https://private-user-images.githubusercontent.com/54092915/365424721-58d2616c-8c04-43e4-b959-81869ac148d4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTk0MTksIm5iZiI6MTczOTE5OTExOSwicGF0aCI6Ii81NDA5MjkxNS8zNjU0MjQ3MjEtNThkMjYxNmMtOGMwNC00M2U0LWI5NTktODE4NjlhYzE0OGQ0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDE0NTE1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMxMmNmYzZkYzg2ZmI3NmEyNmJjODM4NGI4OTRkMDJlYWQ5OGY3MTY2YTE1ODM2NzNlOTE2ODViNmMwMjg4MTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.59ityKaeAjjNV0p_vzT3uGL0KNYIy9peeb53_xvnjAw)
Checklist:
flake8
and fix issues.pytest
no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.