Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add GitHub workflow to run code linting checks daily, on push, and on pull request. #11

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

Bill-hbrhbr
Copy link
Collaborator

@Bill-hbrhbr Bill-hbrhbr commented Jan 23, 2025

Description

With the first set of linters added (for YAML files), automated GitHub workflow to lint files can now be set up.
This is important before we add more configuration YAML files to the project.

The linting workflow file follows the current practice in clp, with three differences:

  1. Changed the workflow name from clp-lint to code-linting-checks, which is more generic.
  2. Added permissions: {}, which disables all token permissions. This enhances security for workflows where no repository interactions are required.
  3. Added a job Log tool versions for better debuggability.

For details, see spider.

Validation performed

  • Verified that all current workflows pass.

@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion January 23, 2025 20:58
@davidlion davidlion changed the title ci: Add GitHub workflow to run code linting checks daily and on every push or pull request. ci: Add GitHub workflow to run code linting checks daily, on push, and on pull request. Jan 23, 2025
@davidlion davidlion merged commit 16b2700 into y-scope:main Jan 23, 2025
5 checks passed
@Bill-hbrhbr Bill-hbrhbr deleted the add-lint-workflow branch February 3, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants