Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ionic repulsion, parquet output, rename out file, and lots of bugfixes #10

Merged
merged 12 commits into from
Feb 17, 2025

Conversation

y1zhou
Copy link
Owner

@y1zhou y1zhou commented Feb 17, 2025

Added

  • Detection of repulsion between like charges
  • Support of parquet, json, and ndjson output formats
  • Added a -name flag in the CLI to rename the output file of contacts and sasa commands

Fixed

  • Checks for polar contacts were skipped when hydrogen bond criteria are not satisfied
  • Better error messages when rings have missing atoms for finding the center and normal vector
  • Nomenclature mix of residue insertion codes and alternative locations; the two are now stored under separate columns (*_insertion and *_altloc) in the output files

Changed

  • Distance cutoff for T-shaped Pi-stacking lowered from 6Å to 5Å
  • Added hydrogen bond distance check to better differentiate Hbonds and polar contacts
  • Performance/memory footprint improvement by switching from 64-bit numbers to 32-bit
  • Logging is now less verbose

@y1zhou y1zhou merged commit c192255 into master Feb 17, 2025
1 check passed
@y1zhou y1zhou deleted the feat/pathology branch February 17, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant