Bump serialport package version to ^11.0.0

[AlessandroAU]

There is an upstream error with a certain binary release of the serialport package. It was caused by a maintainer updating libc and this broke cross-compilation on ARM targets and hence a faulty release binary was circulated into the wild. (It was fixed here: fix: update build tools and fix arm64 build for rpi by reconbot · Pull Request #111 · serialport/bindings-cpp).

Some additional reports are here:
node-red-node-serialport node makes the Docker container infinite boot cycle · Issue #894 · node-red/node-red-nodes

[email protected] fails in docker container on rpi · Issue #2438 · serialport/node-serialport

Node-RED (Docker) crashes when /dev/ttyACM0 is configured in flow - Raspberry Pi 4 · Issue #3461 · node-red/node-red

The issue is fixed in version 11.0.0

[yaacov]

Thanks !

[Jalle19]

Can you make a new release?

[Jalle19]

The test suite is broken since this was merged

[Jalle19]

Ah, it was apparently ninja-fixed in 33b52c0

[yaacov]

Can you make a new release?

https://www.npmjs.com/package/modbus-serial/v/8.0.12 🎉

[Jalle19]

Sadly, after bumping from 8.0.11 to 8.0.12, Modbus RTU no longer works properly:

2023-08-29T09:54:22.765Z [modbus] debug: Retrieving device information...
2023-08-29T09:54:22.767Z [modbus] debug: Reading coil address 16, length 1
2023-08-29T09:54:22.784Z [modbus] debug: Reading coil address 72, length 1
2023-08-29T09:54:22.799Z [modbus] debug: Reading holding register address 154, length 1
2023-08-29T09:54:22.815Z [modbus] debug: Reading holding register address 171, length 1
2023-08-29T09:54:27.816Z [modbus] error: Failed to read holding register address 171, length 1
2023-08-29T09:54:27.816Z [main] error: An exception occurred: TransactionTimedOutError: Timed out

[yaacov]

Sadly, after bumping from 8.0.11 to 8.0.12, Modbus RTU no longer works properly:

2023-08-29T09:54:22.765Z [modbus] debug: Retrieving device information...
2023-08-29T09:54:22.767Z [modbus] debug: Reading coil address 16, length 1
2023-08-29T09:54:22.784Z [modbus] debug: Reading coil address 72, length 1
2023-08-29T09:54:22.799Z [modbus] debug: Reading holding register address 154, length 1
2023-08-29T09:54:22.815Z [modbus] debug: Reading holding register address 171, length 1
2023-08-29T09:54:27.816Z [modbus] error: Failed to read holding register address 171, length 1
2023-08-29T09:54:27.816Z [main] error: An exception occurred: TransactionTimedOutError: Timed out

can you find the issue ?
do I need to remove this release ?

[Jalle19]

I'm not sure, it must be related to the serialport version bump. I'd pull the release for now.

[yaacov]

ok 8.0.12 is detracted

[Jalle19]

#505 similar report

[yaacov]

@Jalle19 can you try https://www.npmjs.com/package/modbus-serial/v/8.0.13 ?

[Jalle19]

Seems to work! I can't find the relevant commits here on GitHub though, what did you change?

[yaacov]

I reverted #507

[yaacov]

looks like this was the offending code:
https://github.com/yaacov/node-modbus-serial/pull/510/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346