use built in uuid instead #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redonkulus
reviewed
Jan 9, 2024
There was a problem hiding this comment.
@jimmywarting Thanks for adding this. Would we need to bump the major version to avoid any breaking changes?
Also you will need to rebase from main.
| @@ -1,23 +1,9 @@ | |||
| /* global describe, it, beforeEach */ | |||
| 'use strict'; | |||
|
|
|||
| // temporarily monkeypatch `crypto.randomBytes` so we'll have a | |||
There was a problem hiding this comment.
@jimmywarting is this not an issue with the built in UUID generator?
|
Would it better to use some form of getRandomValues
randomUUID
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
use built in uuid instead of depending on some dependency to do it