Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMYK PTIFF generation #1254

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix CMYK PTIFF generation #1254

wants to merge 2 commits into from

Conversation

mikeapp
Copy link
Contributor

@mikeapp mikeapp commented Aug 25, 2023 •
edited
Loading

This PR fixes two issues:

  • CMYK color profiles are not converted to sRGB successfully
  • After conversion of the primary image, the compression applied in the generation of the PTIFF via tiffcp causes a failure, even if the constituent TIFFs all have an sRGB profile.

This needs further testing and we need to understand how many CMYK images we are likely to encounter, since the resulting files will be larger w/o compression.

@mikeapp mikeapp mentioned this pull request Aug 25, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikeapp