Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate steps partially #277

Merged

Conversation

RamyAlshurafa
Copy link
Member

@RamyAlshurafa RamyAlshurafa commented Jan 25, 2023

Issues this PR relates to

#225

Note

when the user goes to the landing page, the page requests all the steps, so we translate all the steps at once, which makes the translation API respond with too many requests errors.
this fix is to change the get steps logic, only to get the title and the description for the steps, so we translate these two fields, and when the user views a single step we translate the whole step. this makes fewer data to be translated at the same time

=======

NOTE: REMEMBER NOT TO REVIEW UNLESS ALL ACCEPTANCE CRITERIA HAS BEEN TICKED OFF


Any info the reviewer needs to know to test

e.g. Add env vars, run npm install


Any info the team needs to consider before merged into development

e.g. Will a database need to be rebuilt (and is this ok if existing data), add env vars


Quick Pull Request Checklist

Please make sure you ensure the following has been done before marking your PR as awaiting-review.

  • Branch is up to date with develop
  • Project runs
  • You can download and install locally, and run the project locally
  • All existing and new features run without bugs
  • Checked that features/design works across all agreed browsers + devices
  • The new work has been checked with Axe accessibility checker and doesn't throw significant errors
  • Linter is used
  • Code is consistent with agreed team style
  • Naming of files is consistent with project
  • Tests all pass
  • No console logs

@cemalokten
Copy link
Contributor

@RamyAlshurafa The same issues seem to be happening as before, inconsistent gaps in the translations:

GET /api/steps?lng=fi

Screenshot 2023-01-25 at 15 13 35

Screenshot 2023-01-25 at 15 11 29

Screenshot 2023-01-25 at 15 11 51

@RamyAlshurafa RamyAlshurafa temporarily deployed to hyde-dev January 26, 2023 09:31 Inactive
@RamyAlshurafa RamyAlshurafa temporarily deployed to hyde-dev January 26, 2023 10:01 Inactive
@cemalokten cemalokten merged commit e7c0663 into develop Jan 26, 2023
@cemalokten cemalokten deleted the 225-fix-steps-translations-by-minimize-translated-data branch January 26, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants