Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RV, RL] rework RCS blocks #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MinchinWeb
Copy link
Collaborator

Further to your comment on #20, this is my attempt to make sense of RCS blocks.

I don't know if there was a previous naming system that I totally ignored here. I somewhat wish that I could figure out is how to drop the leading zero, but there are certain blocks that have thrust power of 10 or 12 (or in one case, 100!). It's also slightly weird to multiple the thruster power by 10 (do we do that for any other series?), but not doing so would require lots of decimals.

As always, comments / suggestions / recommendations / concerns / alternatives are welcome.

@yalov
Copy link
Owner

yalov commented Jun 27, 2024

Hi, about the current system of naming what I was using:

As base I have used the stock RV-105 as 1 thrust power, and RV-01X as 0.1 trust power — that is pretty standartize number-wize (first 2 digits 10 — 1 thrust, 01 — 0.1 thrust).
Then, for RCS what is stockalike enough, I have used exactly the same convension: from RV-01 for 0.1 thrust to RV-99 — 9.9 thrust, etc.
At the time I also was trying to save as much of original name as possible. (AVCS-3 -> VS-3)

Next, for create and sort any other groups (Near Future the higher ISP blocks as example) I use different second letter, without a system, just for an order: RW for some of Near Future hight ISP, RY for spaceY, mk2 and mk3 segments use the mk2 and mk3.

I like the idea of a letter specify high ISP, and H for high is probably more clear than B.

I have used the RV-105 "Place-Anywhere 7" Linear RCS Port so it's right before the RV-105x2 — RV-105x5, but now there is only
one part with variants, so it make sence to specify thrust 2.0 (RV-210)

Next about the multiply by 10 — the stack size itself is like that — 12, 25, 50, etc.
Also I am not consirering that multiply by 10, it is like giving 1 more precision digit after the floating point, but without the floating point, because it is not necessary for sorting, and I have not liked the point in the title as just float point, because it looks like something more — like a 2 numbers splitted by point.

So, for example, there are numbers from 1 to 99.9 "sorted", where only sorting matter, but not a view of an number, so 1692< 50, but by viewing 1692 it is impossible to say that it is 16.92, and not the 1692.

01
05
062
078
09
10
123
15
1692
50
65
722
999

Lets start there with having separate groups back:
for rcs from mk2+ and mk3+, because they are pretty unique in the formfactor, and usually used for mk2 and mk3 fuselages,
and for near future high isp, because there are several of those and they create a group.
If you have something in mind that is better than just RW, RX, RY — use new groups names.

Then, with reverting to use stock RV-105x5 and RV-010x5, because the stock RV-105 is also like a name. Then, scale other thrust numbers in respect to that.

And with using H instead of B — for high ISP.

@MinchinWeb
Copy link
Collaborator Author

Ok, I've reworked the RCS blocks in line with your comments.

RV-105 is an RCS block with a thruster power to 1.0 and (up to) 5 directional ports. This removes the leading zero from most. And I can live with the multiply by 10.

I've created a group with the prefix for RVa- for high thrust RCS blocks; this don't multiply their thrust.

For thruster values, I've used "99" for "100" to keep from needing an extra leading zero.

I'm not using H for high efficiency thrusters.

The spec has been updated accordingly.

Other than that, I haven't broken the group apart. The "Mk2" and "Mk3" blocks are surface mounted like the rest (and not really "Mk2" shaped) so I've kept them in the same group.

Hopefully this works better!

@MinchinWeb MinchinWeb mentioned this pull request Jul 4, 2024
@MinchinWeb
Copy link
Collaborator Author

This is now just the RCS block reworking. Other changes have been moved to #25. If you want the old commits, they are in a rcs-2 branch on my fork.

@yalov
Copy link
Owner

yalov commented Jul 4, 2024

mk3 "5-way" RCS is just a surface mounted rcs, but 2 caps and 2 segments intended for an egde of mk3 tank:

screenshot0_cr

that is why I want caps and segments (but not the "5-way") to be in the mk3 group.

the same for the mk2 mod (the "chine" is for an edge of mk2 tank (before there was also several parts instead of the variants)

screenshot22_cr

Also, the Near Future Spacecraft thrust 1.0 High ISP RCS — it is like upgrade to stock or RLA Reborn sets, so make them alter in the part list with the outdated thrust 1.0 rcs looks strange.

That why I want them to have separate groups.

finally about numbers, I have double checked, I so used to RV-105x5, RV-105x4, etc.., so I forgot it never was the stock titles, and for example the restock by default also don't use the "x" delimiter for "power x nozzles", but some other mods does.

  1. The old system (that I used to) I like the most:
    RV-105x5 — thrust: 1.05 ~ close enough to 1.00, nozzles 5;
    RV-025x3 - thrust 0.25, nozzles 3, etc,
    pros is that beginning of the title of the stock part RV-105 is not changed, so if there is unsupported by CPT mods with parts RV-103 "Whatever", RV-106-AN "Another", etc — then the order is not changed, RV-105 or RV-105x5 will be in-between.

  2. then probably RV-10x5 — thrust: 1.0, nozzles 5, it's close enough to stock, and "deterministic", without the 1.05 ~ close enough to 1, but it breaks scenario above (supporting unsupported mods), and RV-106 will be before RV-10x5

  3. and RV-105 — (without "x") as thrust: 1.0, nozzles 5 is the shortest, it doesn't breaks scenario above, but it is more difficult to parse thrust and nozzle from the same number.

iirc the game ignores the "-" in titles for sorting, so RV-10-5 is another variant. it will be in-beween RV-103 and RV-106, and separate visually the thrust and the nozzles.

Also for larger numbers the hexa-decagonal numbering could be used: A0 for 10, C0 for 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants