Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch a built system to vite #1696

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from
Draft

Switch a built system to vite #1696

wants to merge 35 commits into from

Conversation

NiEkOKsU
Copy link
Contributor

@NiEkOKsU NiEkOKsU commented Aug 8, 2024

No description provided.

@NiEkOKsU NiEkOKsU linked an issue Aug 8, 2024 that may be closed by this pull request
3 tasks
@NiEkOKsU NiEkOKsU marked this pull request as draft August 8, 2024 19:48
@NiEkOKsU NiEkOKsU self-assigned this Aug 28, 2024
@NiEkOKsU
Copy link
Contributor Author

At the moment I've got such error while trying to build app for production
image

@grzanka
Copy link
Contributor

grzanka commented Sep 19, 2024

At the moment I've got such error while trying to build app for production image

what chatgpt says if you give him the code and the error message ?

another issue - please rebase your branch or include newest master changes. There is a lot of conflicts

@NiEkOKsU
Copy link
Contributor Author

At the moment I've got such error while trying to build app for production image

what chatgpt says if you give him the code and the error message ?

another issue - please rebase your branch or include newest master changes. There is a lot of conflicts

After a fight with gpt i correct that error, i have used a rollup library by mistake in one place in vite.config.mts

@NiEkOKsU NiEkOKsU marked this pull request as ready for review September 22, 2024 11:16
@NiEkOKsU NiEkOKsU marked this pull request as draft September 22, 2024 11:42
@grzanka
Copy link
Contributor

grzanka commented Sep 22, 2024

@NiEkOKsU fix failing tests !

import expectedGeoText from 'src/libs/converter/tests/shieldhit/resources/expected_shieldhit_output/geo.dat?raw';
import expectedMatText from 'src/libs/converter/tests/shieldhit/resources/expected_shieldhit_output/mat.dat?raw';

// In expected output file we have characters that do not appear in the file generated by simulator, they should be removed to get truth in comparison
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention these characters here in the comment, its hard to guess from regexp what is that ?
I see some whitespace, but what else ?

@grzanka
Copy link
Contributor

grzanka commented Oct 3, 2024

@NiEkOKsU this is how yap-dev looks like after loading an example.
Seems like threejs not working ?

image

try logging to https://yap-dev.c3.plgrid.pl and see yourselves

@NiEkOKsU NiEkOKsU marked this pull request as draft October 3, 2024 20:12
# related to the paths of static assets in a React application.
# The bug is caused by a known issue in the create-react-app package,
# which results in duplicate static/js entries in the paths of some chunk files.
RUN npm run fix-web-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that this issue won't be a problem again:
#640

Copy link
Contributor

@grzanka grzanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments inline

@grzanka
Copy link
Contributor

grzanka commented Oct 7, 2024

It seems threejs works somehow (I only tested on gitpod), let me know once this is ready for tests on the yap-dev

@grzanka
Copy link
Contributor

grzanka commented Nov 6, 2024

@NiEkOKsU I saw this warning on master branch:

One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

do you think it will disappear with this PR ?

@NiEkOKsU
Copy link
Contributor Author

NiEkOKsU commented Nov 6, 2024

@NiEkOKsU I saw this warning on master branch:

One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

do you think it will disappear with this PR ?

It should disappear with this PR. We use here vite instead of create react app to start/build app, so dependencies from create react app shouldn't apper. At least I don't see anything similar to this warning here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up build time
2 participants