-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch a built system to vite #1696
base: master
Are you sure you want to change the base?
Conversation
@NiEkOKsU fix failing tests ! |
import expectedGeoText from 'src/libs/converter/tests/shieldhit/resources/expected_shieldhit_output/geo.dat?raw'; | ||
import expectedMatText from 'src/libs/converter/tests/shieldhit/resources/expected_shieldhit_output/mat.dat?raw'; | ||
|
||
// In expected output file we have characters that do not appear in the file generated by simulator, they should be removed to get truth in comparison |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention these characters here in the comment, its hard to guess from regexp what is that ?
I see some whitespace, but what else ?
@NiEkOKsU this is how yap-dev looks like after loading an example. try logging to https://yap-dev.c3.plgrid.pl and see yourselves |
# related to the paths of static assets in a React application. | ||
# The bug is caused by a known issue in the create-react-app package, | ||
# which results in duplicate static/js entries in the paths of some chunk files. | ||
RUN npm run fix-web-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope that this issue won't be a problem again:
#640
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments inline
src/ThreeEditor/components/Sidebar/properties/fields/PropertyField.tsx
Outdated
Show resolved
Hide resolved
src/ThreeEditor/Simulation/CustomStoppingPower/CustomStoppingPower.ts
Outdated
Show resolved
Hide resolved
src/ThreeEditor/Simulation/CustomStoppingPower/CustomStoppingPower.ts
Outdated
Show resolved
Hide resolved
It seems threejs works somehow (I only tested on gitpod), let me know once this is ready for tests on the yap-dev |
@NiEkOKsU I saw this warning on master branch:
do you think it will disappear with this PR ? |
It should disappear with this PR. We use here vite instead of create react app to start/build app, so dependencies from create react app shouldn't apper. At least I don't see anything similar to this warning here. |
No description provided.