Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic coloring based on a given answer. #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dclamage
Copy link

@dclamage dclamage commented Nov 23, 2022

This is more of a proof of concept but maybe it'll give you a bit of a head start if you decide to implement this feature. Basically, many times I will use the bot to see how well I did on a game I just played and see what it would have suggested, how it would have played, etc. In those cases, I know what the answer is.

This PR adds a text box where you can fill the known answer. Then, when you type in any word, that word gets automatically colored based on the answer provided. This is a convenience feature to make coloring faster when the answer is known. I mostly tested in Wordle mode, so I'm unsure how it would behave in other modes, or perhaps it should be limited only to modes where there is a single answer. I wasn't sure exactly how to do that or what design you'd want.

Anyway, I'm hopeful my contribution here is useful in some way.

@dclamage dclamage marked this pull request as ready for review November 23, 2022 01:12
@ybenhayun
Copy link
Owner

Hey, this is a really neat idea! Coloring in the rows should be the same across all bots, because they all call the same "bot.setRowColor" function, but the multi word answer bots would need the ability to enter in multiple words.

I'm surprised you were able to figure this out-- there's still quite a lot of spaghetti code littered through project that I'm trying to fix haha

@dclamage
Copy link
Author

Thanks! I was mostly concerned about the UX aspect especially if there were multiple answers. And whether this should be an expando or something to prevent confusion about it being optional. I'm not very good at frontend stuff though, so I figured I'd check in with you first about all this, and whether you'd want to handle the rest yourself or if you'd like me to make adjustments myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants