This repository has been archived by the owner on Jan 27, 2019. It is now read-only.
Renamer XmlSerializer compability #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for the fix. It looks like your change detects SerializableAttribute and prevent properties to be renamed when the class is Serializable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compability with XmlSerializer, or any other serializer for that matter.
Previously: renamed classes that were meant to be serialized {more than likely caused errors)
Now: does not rename classes marked [Serialized], nor any fields of this class (because XmlSerializer ignores [NonSerialized])
Just can't seem to detect [XmlIgnoreAttribute] for whatever reason (see code).